[SELC-7729] fix: set isTest only if it is true in findAndActivate in DelegationConnectorImpl (#118)

Author: duffizipierluigi

apps/institution-ms/connector/dao/src/main/java/it/pagopa/selfcare/mscore/connector/dao/DelegationConnectorImpl.java

@@ -167,7 +167,9 @@ public Delegation findAndActivate(String from, String to, String productId, Bool
         update.set(DelegationEntity.Fields.updatedAt.name(), OffsetDateTime.now());
         update.set(DelegationEntity.Fields.closedAt.name(), null);
         update.set(DelegationEntity.Fields.status.name(), DelegationState.ACTIVE);
-        update.set(DelegationEntity.Fields.isTest.name(), isTest);
+        if(Boolean.TRUE.equals(isTest)){
+            update.set(DelegationEntity.Fields.isTest.name(), true);
+        }
         FindAndModifyOptions findAndModifyOptions = FindAndModifyOptions.options().upsert(false).returnNew(true);
         return delegationMapper.convertToDelegation(repository.findAndModify(query, update, findAndModifyOptions, DelegationEntity.class));
     }

apps/institution-ms/connector/dao/src/test/java/it/pagopa/selfcare/mscore/connector/dao/DelegationConnectorImplTest.java

@@ -253,21 +253,52 @@ void find_shouldGetDataPaginated() {
     }
 
     @Test
-    void findAndActivate() {
+    void findAndActivate_shouldSetIsTest() {
         DelegationEntity delegationEntity = new DelegationEntity();
         delegationEntity.setId("id");
         delegationEntity.setFrom("from");
         delegationEntity.setTo("to");
         delegationEntity.setProductId("prod-io");
         delegationEntity.setStatus(DelegationState.ACTIVE);
         delegationEntity.setIsTest(true);
-        when(delegationRepository.findAndModify(any(), any(), any(), any())).thenReturn(delegationEntity);
+        ArgumentCaptor<Update> updateCaptor = ArgumentCaptor.forClass(Update.class);
+        when(delegationRepository.findAndModify(any(), updateCaptor.capture(), any(), any())).thenReturn(delegationEntity);
         Delegation delegation = delegationConnectorImpl.findAndActivate(delegationEntity.getFrom(), delegationEntity.getTo(), delegationEntity.getProductId(), delegationEntity.getIsTest());
+        Update update = updateCaptor.getValue();
+        Document updateDoc = update.getUpdateObject();
+
+        assertTrue(updateDoc.containsKey("$set"));
+        Document setDoc = (Document) updateDoc.get("$set");
+        assertTrue(setDoc.containsKey(DelegationEntity.Fields.isTest.name()));
+        assertNotNull(setDoc.get(DelegationEntity.Fields.isTest.name()));
+        assertEquals(delegationEntity.getIsTest(), setDoc.get(DelegationEntity.Fields.isTest.name()));
         assertNotNull(delegation);
         assertEquals(delegation.getId(), delegationEntity.getId());
         assertEquals(delegation.getIsTest(), delegationEntity.getIsTest());
     }
 
+    @Test
+    void findAndActivate_shouldNotSetIsTest() {
+        DelegationEntity delegationEntity = new DelegationEntity();
+        delegationEntity.setId("id");
+        delegationEntity.setFrom("from");
+        delegationEntity.setTo("to");
+        delegationEntity.setProductId("prod-io");
+        delegationEntity.setStatus(DelegationState.ACTIVE);
+        ArgumentCaptor<Update> updateCaptor = ArgumentCaptor.forClass(Update.class);
+        when(delegationRepository.findAndModify(any(), updateCaptor.capture(), any(), any())).thenReturn(delegationEntity);
+        Delegation delegation = delegationConnectorImpl.findAndActivate(delegationEntity.getFrom(), delegationEntity.getTo(), delegationEntity.getProductId(), delegationEntity.getIsTest());
+        Update update = updateCaptor.getValue();
+        Document updateDoc = update.getUpdateObject();
+
+        assertTrue(updateDoc.containsKey("$set"));
+        Document setDoc = (Document) updateDoc.get("$set");
+        assertFalse(setDoc.containsKey(DelegationEntity.Fields.isTest.name()));
+        assertNull(setDoc.get(DelegationEntity.Fields.isTest.name()));
+        assertNotNull(delegation);
+        assertEquals(delegation.getId(), delegationEntity.getId());
+    }
+
     @Test
     void findAndCount_shouldGetData() {