[SELC-8074] feat: added check to atecoCodes (#946)

Author: gianmarcoplutino

apps/onboarding-ms/src/main/java/it/pagopa/selfcare/onboarding/entity/registry/RegistryManagerPDNDInfocamere.java

@@ -13,34 +13,58 @@
 import org.openapi.quarkus.user_registry_json.model.SaveUserDto;
 import org.openapi.quarkus.user_registry_json.model.UserSearchDto;
 
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+
+import static it.pagopa.selfcare.onboarding.common.ProductId.PROD_IDPAY_MERCHANT;
+
 public class RegistryManagerPDNDInfocamere extends ClientRegistryPDNDInfocamere {
 
     public static final String USERS_FIELD_TAXCODE = "fiscalCode";
 
     private final UserApi userRegistryApi;
+    private final Optional<String> allowedAtecoCodes;
 
-    public RegistryManagerPDNDInfocamere(Onboarding onboarding, InfocamerePdndApi infocamerePdndApi, UserApi userRegistryApi) {
+    public RegistryManagerPDNDInfocamere(Onboarding onboarding, InfocamerePdndApi infocamerePdndApi, UserApi userRegistryApi,
+                                        Optional<String> allowedAtecoCodes) {
         super(onboarding, infocamerePdndApi);
         this.userRegistryApi = userRegistryApi;
+        this.allowedAtecoCodes = allowedAtecoCodes;
     }
 
     @Override
     public Uni<Onboarding> customValidation(Product product) {
-        if (InstitutionType.PRV_PF.equals(onboarding.getInstitution().getInstitutionType())) {
-            final String fiscalCode = onboarding.getInstitution().getTaxCode();
-            final UserSearchDto searchDto = new UserSearchDto().fiscalCode(fiscalCode);
-            return userRegistryApi.searchUsingPOST(USERS_FIELD_TAXCODE, searchDto)
-                    .onItem().transform(userResource ->
-                            updateOnboardingWithUserId(onboarding, userResource.getId().toString())
-                    )
-                    .onFailure(WebApplicationException.class)
-                    .recoverWithUni(ex ->
-                            handleSearchFailure((WebApplicationException) ex, onboarding, fiscalCode)
-                    );
+        if (isIdPayMerchantProduct(product)) {
+            return validateAtecoCodes();
+        }
+        if (isPrivatePersonInstitution()) {
+            return manageTaxCode();
         }
         return Uni.createFrom().item(onboarding);
     }
 
+    private boolean isIdPayMerchantProduct(Product product) {
+        return Objects.nonNull(product) && PROD_IDPAY_MERCHANT.getValue().equals(product.getId());
+    }
+
+    private boolean isPrivatePersonInstitution() {
+        return InstitutionType.PRV_PF.equals(onboarding.getInstitution().getInstitutionType());
+    }
+
+    private Uni<Onboarding> manageTaxCode() {
+        final String fiscalCode = onboarding.getInstitution().getTaxCode();
+        final UserSearchDto searchDto = new UserSearchDto().fiscalCode(fiscalCode);
+        return userRegistryApi.searchUsingPOST(USERS_FIELD_TAXCODE, searchDto)
+                .onItem().transform(userResource ->
+                        updateOnboardingWithUserId(onboarding, userResource.getId().toString())
+                )
+                .onFailure(WebApplicationException.class)
+                .recoverWithUni(ex ->
+                        handleSearchFailure((WebApplicationException) ex, onboarding, fiscalCode)
+                );
+    }
+
     /**
      * Gestisce il fallimento della ricerca utente. Se l'errore è un 404 (Not Found),
      * procede con la creazione di un nuovo utente. Altrimenti, propaga l'errore.
@@ -75,6 +99,31 @@ private Onboarding updateOnboardingWithUserId(Onboarding onboarding, String user
         return onboarding;
     }
 
+    /**
+     * Valida che almeno uno dei codici ATECO dell'istituzione sia presente nella lista di codici ATECO consentiti.
+     * @return Uni<Void> che fallisce con InvalidRequestException se la validazione fallisce
+     */
+    private Uni<Onboarding> validateAtecoCodes() {
+        List<String> institutionAtecoCodes = onboarding.getInstitution().getAtecoCodes();
+        
+        if (Objects.isNull(institutionAtecoCodes) || institutionAtecoCodes.isEmpty()) {
+            return Uni.createFrom().failure(new InvalidRequestException("Institution must have at least one ATECO code"));
+        }
+
+        List<String> allowedCodes = allowedAtecoCodes
+                .filter(codes -> !codes.trim().isEmpty())
+                .map(codes -> List.of(codes.split(",")))
+                .orElseThrow(() -> new InvalidRequestException("Allowed ATECO codes are not configured"));
+        boolean hasValidAteco = institutionAtecoCodes.stream()
+                .anyMatch(ateco -> allowedCodes.contains(ateco.trim()));
+
+        if (!hasValidAteco) {
+            return Uni.createFrom().failure(new InvalidRequestException("Institution ATECO codes are not allowed for this product"));
+        }
+
+        return Uni.createFrom().item(onboarding);
+    }
+
     @Override
     public Uni<Boolean> isValid() {
         /*if (!originPDNDInfocamere(onboarding, registryResource)) {

apps/onboarding-ms/src/main/java/it/pagopa/selfcare/onboarding/entity/registry/RegistryResourceFactory.java

@@ -8,10 +8,13 @@
 import it.pagopa.selfcare.onboarding.entity.Onboarding;
 import jakarta.enterprise.context.ApplicationScoped;
 import jakarta.inject.Inject;
+import org.eclipse.microprofile.config.inject.ConfigProperty;
 import org.eclipse.microprofile.rest.client.inject.RestClient;
 import org.openapi.quarkus.party_registry_proxy_json.api.*;
 import org.openapi.quarkus.user_registry_json.api.UserApi;
 
+import java.util.Optional;
+
 @ApplicationScoped
 public class RegistryResourceFactory {
 
@@ -55,11 +58,14 @@ public class RegistryResourceFactory {
     @Inject
     GeographicTaxonomiesApi geographicTaxonomiesApi;
 
+    @ConfigProperty(name = "onboarding-ms.allowed-ateco-codes")
+    Optional<String> allowedAtecoCodes;
+
   public RegistryManager<?> create(Onboarding onboarding, String managerTaxCode) {
     return switch (onboarding.getInstitution().getOrigin() != null
         ? onboarding.getInstitution().getOrigin()
         : Origin.SELC) {
-      case PDND_INFOCAMERE -> new RegistryManagerPDNDInfocamere(onboarding, infocamerePdndApi, userRegistryApi);
+      case PDND_INFOCAMERE -> new RegistryManagerPDNDInfocamere(onboarding, infocamerePdndApi, userRegistryApi, allowedAtecoCodes);
       case ANAC -> new RegistryManagerANAC(onboarding, stationsApi);
       case IVASS -> new RegistryManagerIVASS(onboarding, insuranceCompaniesApi);
       case INFOCAMERE -> new RegistryManagerInfocamere(onboarding, infocamereApi, managerTaxCode);

apps/onboarding-ms/src/main/resources/application.properties

@@ -19,6 +19,7 @@ quarkus.mongodb.database = selcOnboarding
 
 onboarding.institutions-allowed-list=${ONBOARDING_ALLOWED_INSTITUTIONS_PRODUCTS}
 onboarding.orchestration.enabled = ${ONBOARDING_ORCHESTRATION_ENABLED:true}
+onboarding-ms.allowed-ateco-codes = ${ALLOWED_ATECO_CODES}
 
 
 ## SIGNATURE