[SELC-7814] feat: update requesterName in buildCreateEmailDataModel after call from APIM (#308)

Author: duffizipierluigi

apps/user-ms/src/main/java/it/pagopa/selfcare/user/service/UserNotificationServiceImpl.java

@@ -50,6 +50,8 @@ public class UserNotificationServiceImpl implements UserNotificationService {
     public static final String INSTITUTION_NAME = "institutionName";
     public static final String NO_ROLE_FOUND = "no_role_found";
     public static final String PRODUCT_ROLE = "productRole";
+    public static final String DEFAULT_NAME = "Operatore PagoPa";
+
     @Inject
     @RestClient
     EventHubRestClient eventHubRestClient;
@@ -138,7 +140,13 @@ public Uni<Void> sendOtpNotification(String institutionalEmail, String name, Str
 
     private Map<String, String> buildCreateEmailDataModel(LoggedUser loggedUser, Product product, String institutionDescription, List<String> productRoleCodes) {
         Map<String, String> dataModel = new HashMap<>();
-        dataModel.put(REQUESTER_NAME, Optional.ofNullable(loggedUser.getName()).orElse(""));
+
+        if(Objects.equals(loggedUser.getName(), "apim")){
+            dataModel.put(REQUESTER_NAME, DEFAULT_NAME);
+        } else {
+            dataModel.put(REQUESTER_NAME, Optional.ofNullable(loggedUser.getName()).orElse(""));
+        }
+
         dataModel.put(REQUESTER_SURNAME, Optional.ofNullable(loggedUser.getFamilyName()).orElse(""));
 
         dataModel.put(PRODUCT_NAME, Optional.ofNullable(product.getTitle()).orElse(""));

apps/user-ms/src/test/java/it/pagopa/selfcare/user/service/UserNotificationServiceImplTest.java

@@ -2,6 +2,8 @@
 
 import com.microsoft.applicationinsights.TelemetryClient;
 import freemarker.template.Configuration;
+import freemarker.template.Template;
+import freemarker.template.TemplateException;
 import io.quarkus.test.InjectMock;
 import io.quarkus.test.junit.QuarkusTest;
 import io.smallrye.mutiny.Uni;
@@ -30,6 +32,7 @@
 import org.openapi.quarkus.user_registry_json.model.WorkContactResource;
 
 import java.io.IOException;
+import java.io.Writer;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -351,6 +354,53 @@ void testSendCreateUserNotification() throws IOException {
         verify(mailService, times(1)).sendMail(anyString(), anyString(), anyString());
     }
 
+    @Test
+    void testSendCreateUserNotification_whenLoggedUserIsFromApim_shouldUseDefaultName() throws IOException, TemplateException {
+        // Arrange
+        LoggedUser loggedUser = LoggedUser.builder()
+                .name("apim")
+                .build();
+
+        Configuration freemarkerConfig = mock(Configuration.class);
+        CloudTemplateLoader cloudTemplateLoader = mock(CloudTemplateLoader.class);
+        Template mockTemplate = mock(freemarker.template.Template.class);
+
+        when(freemarkerConfig.getTemplate(anyString())).thenReturn(mockTemplate);
+        when(freemarkerConfig.getTemplateLoader()).thenReturn(cloudTemplateLoader);
+
+        ArgumentCaptor<Map<String, String>> dataModelCaptor = ArgumentCaptor.forClass(Map.class);
+        doNothing().when(mockTemplate).process(dataModelCaptor.capture(), any(Writer.class));
+
+        UserNotificationServiceImpl userNotificationService = new UserNotificationServiceImpl(
+                freemarkerConfig, cloudTemplateLoader, mailService, true, telemetryClient
+        );
+
+        when(mailService.sendMail(anyString(), anyString(), anyString()))
+                .thenReturn(Uni.createFrom().voidItem());
+
+        List<String> roleLabels = List.of("code2", "code3");
+
+        // Act
+        userNotificationService.sendCreateUserNotification(
+                        userInstitution.getInstitutionDescription(),
+                        roleLabels,
+                        userResource,
+                        userInstitution,
+                        product,
+                        loggedUser
+                )
+                .subscribe()
+                .withSubscriber(UniAssertSubscriber.create())
+                .awaitItem()
+                .assertCompleted();
+
+        // Assert
+        verify(mockTemplate, times(1)).process(any(Map.class), any(Writer.class));
+        Map<String, String> capturedDataModel = dataModelCaptor.getValue();
+        assertEquals(UserNotificationServiceImpl.DEFAULT_NAME, capturedDataModel.get(UserNotificationServiceImpl.REQUESTER_NAME));
+    }
+
+
     @Test
     void testSendCreateUserNotificationWith2RoleLabel() throws IOException {
         String loggedUserName = "loggedUserName";