%NPC% in player deaths doesn't always show the NPC the player died too?

[Liam-Nagle]

Checklist

• I'm reporting a problem with Dink
• I've searched the issues and pull requests for similar looking reports

Describe your issue

There seems to be an issue with parsing %NPC% into player deaths. It doensn't always work.

For example in the two screenshots below you can see a death tracked to Ba-Ba but shortly after what should be a death to Zebak isn't tracked and just says %NPC%?

Screenshots

No response

Runelite Logs

I dont think client logs will help for this. I'm happy to try and grab some logs if needs be though

Runelite Version

1.12.10

[Felanbird]

That's not something we offer by default right, you just slapped it inside the death box? I would guess maybe many types of attacks in the game aren't fully tied to their respective NPC and it's just Mr. magic projectile who actually kills you behind the scenes.

[Liam-Nagle]

@Felanbird - It is something that's mentioned in the extra metadata that you guys supply linked below in the json for npc scenarios

https://github.com/pajlads/DinkPlugin/blob/b3437cae48651c18a95fa1aa18dbcfb2f1fe1655/docs/json-examples.md

So I would have thought it would work. But yeah I came to the same conclusion that if a special projectile kills and not the actual boss it doesn't do it. Is this actually working as intended then? The npc death thing seems a bit pointless if so!

[pajlada]

It's a best-effort thing, and if I remember correctly not documented in the template part of the readme for this reason.
For non-Discord integrations, you can handle the null value and output that differently.