Skip to content

Commit 4106e97

Browse files
pajomaclaude
andcommitted
docs: record #51 fix in CHANGELOG and PLAN Phase 1.3
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent eba2a5c commit 4106e97

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111

1212
## Unreleased
1313

14+
### Fixed
15+
* [Issue #51](https://github.com/pajoma/vscode-journal/issues/51) Remote SSH and WSL Remote no longer surface a "File not found" error toast on first-time creation of an entry, weekly page, or note. Replaced the open-before-create antipattern in `Reader.loadEntryForDay`, `Reader.loadEntryForWeek`, and `LoadNotes.loadNote` with a stat-first check (new `fileExists` helper in `src/util/fs-exists.ts`) and migrated the three methods to native `async/await`.
16+
1417
### Changed
1518
* Bumped VS Code engine baseline to `^1.118.0` (was `^1.94.0`). `@types/vscode` and toolchain (TypeScript 5.9, ESLint 9.39, esbuild 0.28, `@vscode/test-cli` 0.0.12, `@vscode/test-electron` 2.5, Mocha 11, `@typescript-eslint/*` 8.59) bumped to current stable.
1619
* Migrated translations from the custom `src/ext/messages.json` system to the stable `vscode.l10n` API. Manifest strings live in `package.nls*.json`; runtime strings in `l10n/bundle.l10n*.json`. All 11 locales preserved (en, de, fr, es, it, pt, nl, ru, zh, ja, ar). Fixed a moment.js escape bug in the Spanish locale carried over from `messages.json`.

PLAN.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ Make sure that, when running on a remote host, the extension can still access th
5757
- [x] `os.homedir()` in `conf.ts`: No change needed — with `extensionKind: ["workspace"]` the extension runs on the remote host, so `os.homedir()` correctly returns the remote home directory where the journal resides
5858
- [x] Replace `untitled:` URI scheme in `writer.ts:createSaveLoadTextDocument()` with `vscode.workspace.fs.writeFile()` + `vscode.workspace.openTextDocument()`
5959
- [x] Add integration test verifying file creation via `vscode.workspace.fs`
60+
- [x] **Followup #51**: First-time entry/week/note creation on Remote SSH and WSL still surfaced VS Code's error toast because all three call sites (`Reader.loadEntryForDay`, `Reader.loadEntryForWeek`, `LoadNotes.loadNote`) used the open-before-create antipattern and relied on prefix-matching the error message text. Replaced with stat-first via a dedicated `fileExists(uri)` helper in `src/util/fs-exists.ts`. Migrated the three methods from `new Promise(...)` wrappers to native `async/await` while there. Regression tests in `src/test/suite/issue-51-remote-create.test.ts`. See [docs/specs/2026-05-14-fix-51-remote-file-creation.md](docs/specs/2026-05-14-fix-51-remote-file-creation.md) and [docs/plans/2026-05-14-fix-51-remote-file-creation.md](docs/plans/2026-05-14-fix-51-remote-file-creation.md).
6061

6162
---
6263

0 commit comments

Comments
 (0)