Merge pull request #204 from pajoma/docs/189-docs-sync-1.1.0

Docs/189 docs sync 1.1.0

Author: pajoma

docs/plans/2026-05-17-200-refactor-week-nav-dedup.md

@@ -0,0 +1,109 @@
+# Plan: Deduplicate week-navigation logic (R3) — #200
+
+**Reference spec:** [docs/specs/2026-05-17-200-refactor-week-nav-dedup.md](../specs/2026-05-17-200-refactor-week-nav-dedup.md)
+
+## Approach
+
+Surgical extraction: move the 6-line block into a new exported function and replace both call sites. No behaviour change. All existing tests are regression guards — they run unchanged and must stay green. New unit tests cover the extracted function directly, without going through the full command layer.
+
+Trade-off: importing `Input` from `'../model'` in `navigation.ts` adds a domain→model dependency that wasn't there before. This is acceptable; `navigation.ts` already returns `Date` objects and `Anchor` structs that the command layer converts to `Input`. Returning an `Input` directly shortens the command glue to two lines.
+
+## Steps
+
+### 1 — Add imports to `src/actions/navigation.ts`
+
+Add at top of file:
+
+```typescript
+import { getWeekFromURIAndConfig } from '../util/paths';
+import { Input } from '../model';
+import moment = require("moment");
+```
+
+**Why:** the new function delegates to `getWeekFromURIAndConfig` (already used by the two command files) and returns an `Input` so callers need zero additional allocation.
+
+### 2 — Add `getAdjacentWeekInput` to `src/actions/navigation.ts`
+
+Export the following function (full body in spec):
+
+```typescript
+export async function getAdjacentWeekInput(
+    editor: vscode.TextEditor | undefined,
+    ctrl: Ctrl,
+    direction: Direction
+): Promise<Input | undefined>
+```
+
+Implementation detail:
+- Guard: if no editor → return `undefined`.
+- Call `getWeekFromURIAndConfig(editor.document.uri, ctrl.config)`.
+- If no match → return `undefined` (caller falls through to daily-entry navigation).
+- Compute adjacent week with `moment().week(weekInfo.week).weekYear(weekInfo.year)[direction === 'previous' ? 'subtract' : 'add'](1, 'week')`.
+- Set `input.week = adj.week()` and return.
+
+**Why:** ternary on `direction` eliminates the only difference between the two duplicated blocks.
+
+### 3 — Refactor `src/provider/commands/open-previous-entry.ts`
+
+- Remove `import { getWeekFromURIAndConfig } from '../../util/paths'`.
+- Remove `import moment = require("moment")`.
+- Replace the duplicated 6-line block with:
+
+```typescript
+const weekInput = await getAdjacentWeekInput(editor, this.ctrl, 'previous');
+if (weekInput) {
+    await this.execute(weekInput);
+    return;
+}
+```
+
+Add `getAdjacentWeekInput` to the import from `'../../actions/navigation'`.
+
+**Why:** removes the dead imports, leaves command as pure glue.
+
+### 4 — Refactor `src/provider/commands/open-next-entry.ts`
+
+Identical to Step 3, but `direction` = `'next'`.
+
+### 5 — Add unit tests
+
+Add a new `suite('getAdjacentWeekInput')` block in `src/test/suite/commands-prev-next.test.ts`, under the existing `helper layer with seeded base` suite. Scenarios:
+
+| # | Name | Setup | Expected |
+|---|------|-------|----------|
+| T1 | no editor | `editor = undefined` | returns `undefined` |
+| T2 | non-weekly file | open a day entry `${tmpBase}/2026/05/16.md` as active | returns `undefined` |
+| T3 | weekly file + next | create and open `${tmpBase}/2026/w20.md`; call with `'next'` | `input.week === 21` |
+| T4 | weekly file + previous | same weekly file; call with `'previous'` | `input.week === 19` |
+
+Seed weekly files using the same `vscode.workspace.fs.createDirectory` + `writeFile` pattern as `seedEntry`. Weekly file naming follows the default pattern: `${year}/w${week}.md`.
+
+**Why:** tests target the pure extracted logic, not the full command stack — fast and focused.
+
+### 6 — Compile and test
+
+```bash
+npm run compile-tests && npm test
+```
+
+Full `npm run check` must pass (lint + compile + test).
+
+## Test scenarios summary
+
+- **T1–T2** (non-weekly): guard conditions; confirm function does not return an Input for inapplicable files.
+- **T3–T4** (weekly): confirm direction-to-add/subtract mapping and that the returned `Input.week` is correct.
+- **Regression**: all 16 existing navigation tests in `commands-prev-next.test.ts` must pass unchanged — they cover the command-layer behaviour end-to-end.
+
+## Dependencies
+
+None. Work is self-contained within this repo and does not require any other PR to land first.
+
+## Risk
+
+**Week-boundary crossing (week 52/53 → week 1):** pre-existing moment behaviour, not changed by this refactoring. Covered by the fact that moment's `.weekYear()` handles it correctly; no test added here since behaviour is unchanged.
+
+**Import cycle:** `navigation.ts` → `../model` → no back-edge into `navigation.ts`. No cycle introduced.
+
+## Rollback
+
+`git revert <commit>` on the single implementation commit. No data migrations, no schema changes.

docs/specs/2026-05-17-200-refactor-week-nav-dedup.md

@@ -0,0 +1,69 @@
+# Spec: Deduplicate week-navigation logic (R3) — #200
+
+## Goal
+
+Extract the identical week-navigation block from `OpenNextEntryCommand` and `OpenPreviousEntryCommand` into a single shared function in `src/actions/navigation.ts`.
+
+## Why now
+
+The block was added to both commands in the same PR (navigation 1.1.0 work). It is not yet stable, so the duplication has not yet masked a divergence bug — but the longer it lives in two places the more likely a future fix lands in only one.
+
+## In scope
+
+- New exported function `getAdjacentWeekInput(editor, ctrl, direction)` in `src/actions/navigation.ts`.
+- Replace the 6-line duplicated block in `open-next-entry.ts` and `open-previous-entry.ts` with a call to the new function.
+- Unit test for `getAdjacentWeekInput` covering: weekly file → correct week returned; non-weekly file → `undefined` returned; direction `next` adds one week; direction `previous` subtracts one week.
+
+## Out of scope
+
+- Any change to the week-number/year-crossing logic (pre-existing moment behaviour).
+- `getWeekFromURIAndConfig` itself (stays in `paths.ts`).
+- UI or command registration changes.
+
+## Acceptance criteria
+
+1. No duplicated week-navigation code remains in the command files.
+2. Both commands behave identically to before — existing navigation tests pass unchanged.
+3. New unit tests for `getAdjacentWeekInput` green.
+4. `npm run check` (lint + compile + test) passes.
+
+## New function contract
+
+```typescript
+// src/actions/navigation.ts
+export async function getAdjacentWeekInput(
+    editor: vscode.TextEditor | undefined,
+    ctrl: Ctrl,
+    direction: Direction            // 'previous' | 'next'
+): Promise<J.Model.Input | undefined>
+```
+
+Returns a populated `Input` (with `input.week` set to the adjacent week number) when the active file is a weekly note, `undefined` otherwise (callers proceed to daily-entry navigation).
+
+**Internals** (replaces the duplicated block):
+
+```typescript
+if (!editor) return undefined;
+const weekInfo = await getWeekFromURIAndConfig(editor.document.uri, ctrl.config);
+if (!weekInfo) return undefined;
+const adj = moment()
+    .week(weekInfo.week)
+    .weekYear(weekInfo.year)
+    [direction === 'previous' ? 'subtract' : 'add'](1, 'week');
+const input = new J.Model.Input();
+input.week = adj.week();
+return input;
+```
+
+## Constraints
+
+- Keep `moment` import in `navigation.ts` (already present).
+- Must remain testable without a live `vscode.TextEditor` — the non-`undefined` code path reaches `getWeekFromURIAndConfig` which calls `config` methods; spy/stub those in tests as done elsewhere.
+
+## Open questions
+
+None.
+
+## Related issues
+
+- Spawned from the navigation work tracked in #144 / docs-sync #189.

l10n/bundle.l10n.de.json

@@ -0,0 +1,19 @@
+{
+  "Today": "Heute",
+  "Tomorrow": "Morgen",
+  "Select entry": "Eintrag auswählen",
+  "Select/Create a note": "Notiz auswählen oder erstellen",
+  "Jump to today's entry.": "Zum Eintrag für heute wechseln.",
+  "Jump to tomorrow's entry.": "Zum Eintrag für morgen wechseln.",
+  "Select from the last journal entries.": "Wählen Sie aus den letzten Journaleinträgen aus.",
+  "Create a new note or select from recently created or updated notes.": "Erstellen Sie eine neue Notiz oder wählen Sie aus den letzten Notizen aus.",
+  "Open notes for week {week}": "Notizen für Kalenderwoche {week} öffnen",
+  "Add task to entry for week {week}": "Aufgabe zum Eintrag für Woche {week} hinzufügen",
+  "Add task to entry {day}": "Aufgabe zum Eintrag {day} hinzufügen",
+  "Add memo to entry {day}": "Memo zum Eintrag {day} hinzufügen",
+  "Create or open entry {day}": "Eintrag {day} erstellen oder öffnen",
+  "[from] dddd": "[vom] dddd",
+  "[from] ll": "[von] ll",
+  "No earlier journal entry found.": "Kein früherer Journaleintrag gefunden.",
+  "No later journal entry found.": "Kein späterer Journaleintrag gefunden."
+}

package.nls.de.json

@@ -0,0 +1,15 @@
+{
+    "command.category.journal": "Journal",
+    "command.journal.today.title": "Heute öffnen",
+    "command.journal.yesterday.title": "Gestern öffnen",
+    "command.journal.tomorrow.title": "Morgen öffnen",
+    "command.journal.memo.title": "Schnellmemo eingeben",
+    "command.journal.note.title": "Neue Journalnotiz",
+    "command.journal.printTime.title": "Uhrzeit einfügen",
+    "command.journal.printDuration.title": "Differenz zwischen ausgewählten Zeiten einfügen",
+    "command.journal.printSum.title": "Summe der ausgewählten Zahlen einfügen",
+    "command.journal.day.title": "Bestimmten Tag öffnen",
+    "command.journal.open.title": "Journal öffnen",
+    "command.journal.openPrevious.title": "Vorherigen Journaleintrag öffnen",
+    "command.journal.openNext.title": "Nächsten Journaleintrag öffnen"
+}