Skip to content

Commit 504c06e

Browse files
committed
docs: post-upgrade accuracy fixes
Final-review followups on the VS Code 1.118 upgrade branch: 1. CLAUDE.md: bumped engine reference from 1.94 to 1.118; replaced the deleted translations.ts/messages.json description with the new vscode.l10n setup (package.nls*.json + l10n/bundle.l10n*.json). 2. PLAN.md Phase 5.4: clarified that getInputDetailsTimeFormat() hardcoded strings remain open (tied to Phase 3 moment removal). 3. tsconfig.json: comment on resolveJsonModule no longer references the deleted translations.json import.
1 parent 3836f4a commit 504c06e

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

CLAUDE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
44

55
## Project
66

7-
VS Code extension (`pajoma.vscode-journal`) for daily markdown journaling. TypeScript, bundled with esbuild, runs in the workspace extension host. Requires Node 20+ and VS Code 1.94+.
7+
VS Code extension (`pajoma.vscode-journal`) for daily markdown journaling. TypeScript, bundled with esbuild, runs in the workspace extension host. Requires Node 20+ and VS Code 1.118+.
88

99
## Commands
1010

@@ -44,7 +44,7 @@ Entry: `src/extension.ts` → `Startup(config).run(context)` (in `src/ext/startu
4444

4545
**Module responsibilities** (need multiple files to grasp):
4646

47-
- `src/ext/` — VS Code surface integration. `Configuration` (`conf.ts`) reads `journal.*` settings and resolves templates/scopes. `Dialogues` drives QuickPick/InputBox. `Startup` wires everything. `translations.ts` + `messages.json` provide i18n.
47+
- `src/ext/` — VS Code surface integration. `Configuration` (`conf.ts`) reads `journal.*` settings and resolves templates/scopes. `Dialogues` drives QuickPick/InputBox. `Startup` wires everything. i18n uses `vscode.l10n` — manifest strings in `package.nls*.json` at the repo root, runtime strings in `l10n/bundle.l10n*.json` (regenerated via `npm run l10n:export`).
4848
- `src/actions/` — Core domain logic, no direct command bindings.
4949
- `Parser` — turns user input/URIs into structured `Input` (date, note, memo, task, weekly).
5050
- `Reader` — loads entries/notes from the configured base directory using `vscode.workspace.fs`.

PLAN.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,9 @@ Make sure that, when running on a remote host, the extension can still access th
175175
- [ ] Clean up `show-pick-list.ts` (219 bytes, likely empty/stub)
176176

177177
### 5.4 — Improve i18n
178-
- [ ] Replace hardcoded locale strings in `getInputDetailsTimeFormat()` with translations from `messages.json`
178+
- [ ] Replace hardcoded locale strings in `getInputDetailsTimeFormat()` (still hardcoded in `src/ext/conf.ts`)
179179
- [x] Add support for VS Code's built-in `vscode.l10n` API (available since 1.73) instead of custom translation system
180-
- [x] Move all user-facing strings to the l10n system
180+
- [x] Move all QuickPick/InputBox user-facing strings to the l10n system (`getInputDetailsTimeFormat()` hardcoded strings remain — tied to moment removal in Phase 3)
181181

182182
---
183183

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"rootDirs": [
1111
"src"
1212
],
13-
"resolveJsonModule": true, /* required to import translations.json */
13+
"resolveJsonModule": true, /* allows importing JSON files in TypeScript source */
1414
/* Strict Type-Checking Option */
1515
"strict": true, /* enable all strict type-checking options */
1616
/* Additional Checks */

0 commit comments

Comments
 (0)