fix(lint): wrap string throws in Error to satisfy no-throw-literal

Replace throw "cancel" / throw "..." with throw new Error("...") in
match-input.ts and dialogues.ts; update cancel-detection checks to
instanceof Error + message === 'cancel'.

#188

Author: pajoma

src/ext/dialogues.ts

@@ -342,7 +342,7 @@ export class Dialogues {
             return value!;
         }
         this.ctrl.logger.debug("User canceled");
-        throw "cancel";
+        throw new Error("cancel");
     }
 
 

src/provider/commands/show-entry-for-date.ts

@@ -45,7 +45,7 @@ export class AbstractLoadEntryForDateCommand implements vscode.Disposable {
             const doc = await this.loadPageForInput(input);
             await this.ctrl.ui.showDocument(doc);
         } catch (error) {
-            if (error !== 'cancel') {
+            if (!(error instanceof Error && error.message === 'cancel')) {
                 this.ctrl.logger.error("Failed to load entry for input: ", input.text, "Reason: ", error);
                 this.ctrl.ui.showError("Failed to open entry.");
             } else { return; }

src/provider/features/match-input.ts

@@ -41,15 +41,15 @@ export class MatchInput {
         this.logger.trace("Entering parseInput() in features/InputMatcher.ts with input string '", inputString, "'");
 
         if (isNullOrUndefined(inputString)) {
-            throw "cancel";
+            throw new Error("cancel");
         }
 
         try {
             const parsedInput = new Input();
 
             const res: RegExpMatchArray | null = inputString.match(this.getExpression());
             if (res === null) {
-                throw "cancel";
+                throw new Error("cancel");
             }
 
             this.logger.trace(Object.entries(res!.groups!).map(([key, value]) => `${key}: ${value}`).join(', '));
@@ -63,7 +63,7 @@ export class MatchInput {
             const userProvidedTemporalToken = this.hasTemporalToken(res!);
 
             if (parsedInput.hasFlags() && !parsedInput.hasMemo()) {
-                throw "No text found for memo or task";
+                throw new Error("No text found for memo or task");
             }
 
             if (!parsedInput.hasFlags() && parsedInput.hasMemo()) {
@@ -90,7 +90,7 @@ export class MatchInput {
         } catch (error) {
             if (error instanceof Error) {
                 this.logger.error("Failed to parse input from string '", inputString, "' do to reason: ", error.message);
-            } else if (error !== "cancel") {
+            } else if (!(error instanceof Error && error.message === "cancel")) {
                 this.logger.error("Failed to parse input from string '", inputString, "'");
             }
             throw error;