refactor(structure): package-by-feature layout + shared/events bus

Phase 4 of #234. Physical reorg from package-by-layer to package-by-feature:

  src/shared/   kernel — model, config, fs, logging, dates, strings,
                templates, paths, events, lang (no feature deps)
  src/features/ entries, notes, weekly, tasks, navigation, smart-input,
                tools (commands/ + domain + ui per feature)
  src/app/      composition root (unchanged)

Add shared/events/JournalEvents (typed vscode.EventEmitter). The inline
weekly daily-link sync in show-entry-for-date now fires an 'entryOpened'
event; the weekly sync subscriber is wired in the Container — removing the
entries->weekly import edge. Behavior unchanged (Container owns the
subscription, so direct-Container tests keep it).

Remaining cross-feature edges (documented for follow-up): entries->notes
(LoadNotes dispatch), navigation->entries (shared base command),
smart-input->entries (Dialogues uses ScanEntries).

Refs #234.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: pajoma

src/app/container.ts

@@ -19,14 +19,17 @@
 'use strict';
 
 import * as vscode from 'vscode';
-import { IConfiguration, IFileSystem, ILogger, IWorkspaceConfigReader, JournalController } from '../model';
-import { Configuration } from '../vscode/conf';
-import { Parser } from '../journal/parser';
-import { Writer } from '../journal/writer';
-import { Reader } from '../journal/reader';
-import { Inject } from '../journal/inject';
-import { Dialogues } from '../vscode/dialogues';
-import { VscodeFileSystem } from '../vscode/vscode-fs';
+import { IConfiguration, IFileSystem, ILogger, IWorkspaceConfigReader, JournalController } from '../shared/model/index';
+import { Configuration } from '../shared/config/configuration';
+import { Parser } from '../features/smart-input/parser';
+import { Writer } from '../features/entries/writer';
+import { Reader } from '../features/entries/reader';
+import { Inject } from '../features/entries/inject';
+import { Dialogues } from '../features/smart-input/dialogues';
+import { VscodeFileSystem } from '../shared/fs/vscode-fs';
+import { JournalEvents } from '../shared/events';
+import { getWeekFromURIAndConfig } from '../shared/paths';
+import { SyncDailyLinks } from '../features/weekly/sync-daily-links';
 
 /**
  * Builds the logger once the configuration is available. The logger needs the
@@ -51,6 +54,7 @@ export class Container implements JournalController {
     public readonly ui: Dialogues;
     public readonly writer: Writer;
     public readonly reader: Reader;
+    public readonly events: JournalEvents;
 
     constructor(configSource: IWorkspaceConfigReader, loggerFactory: LoggerFactory) {
         this.config = new Configuration(configSource);
@@ -62,5 +66,25 @@ export class Container implements JournalController {
         this.writer = new Writer(this.config, this.logger, this.inject, this.fs,
             async (path) => vscode.workspace.openTextDocument(vscode.Uri.file(path)));
         this.reader = new Reader(this.config, this.logger, this.writer, this.ui, this.fs);
+        this.events = new JournalEvents();
+
+        // Cross-feature: when an entry opens, the weekly feature refreshes its
+        // daily-entry links. Wired here (composition root) so the entries
+        // feature need not import the weekly feature.
+        this.events.onEntryOpened(({ doc }) => this.syncWeeklyOnEntryOpened(doc));
+    }
+
+    private syncWeeklyOnEntryOpened(doc: vscode.TextDocument): void {
+        // Fire-and-forget — must never reject the open flow.
+        getWeekFromURIAndConfig(doc.uri, this.config)
+            .then(weekInfo => {
+                if (weekInfo && this.config.getWeeklySyncConfig().enabled) {
+                    const scopeId = weekInfo.scope === 'default' ? undefined : weekInfo.scope;
+                    new SyncDailyLinks(this)
+                        .sync(doc, weekInfo.week, weekInfo.year, scopeId)
+                        .catch(err => this.logger.error("entryOpened weekly sync failed:", err));
+                }
+            })
+            .catch(err => this.logger.error("entryOpened getWeekFromURIAndConfig failed:", err));
     }
 }

src/app/register.ts

@@ -20,14 +20,23 @@
 
 import * as vscode from 'vscode';
 import { Container } from './container';
-import {
-    OpenJournalWorkspaceCommand, OpenNextEntryCommand, OpenPreviousEntryCommand,
-    PrintDurationCommand, PrintSumCommand, PrintTimeCommand, ShiftTaskCommand,
-    ShowEntryForInputCommand, ShowEntryForTodayCommand, ShowEntryForTomorrowCommand,
-    ShowEntryForYesterdayCommand, ShowNoteCommand,
-} from '../commands';
-import { SyncDailyLinks, SyncNoteLinks, WeeklyEntryWatcher } from '../features';
-import { CompletedTaskActions, OpenTaskActions } from '../ui';
+import { OpenJournalWorkspaceCommand } from '../features/tools/commands/open-journal-workspace';
+import { PrintTimeCommand } from '../features/tools/commands/print-current-time';
+import { PrintDurationCommand } from '../features/tools/commands/print-duration-between-selected-times';
+import { PrintSumCommand } from '../features/tools/commands/print-sum-of-selected-numbers';
+import { CopyTaskCommand as ShiftTaskCommand } from '../features/tasks/commands/copy-task';
+import { OpenNextEntryCommand } from '../features/navigation/commands/open-next-entry';
+import { OpenPreviousEntryCommand } from '../features/navigation/commands/open-previous-entry';
+import { ShowEntryForInputCommand } from '../features/entries/commands/show-entry-for-input';
+import { ShowEntryForTodayCommand } from '../features/entries/commands/show-entry-for-today';
+import { ShowEntryForTomorrowCommand } from '../features/entries/commands/show-entry-for-tomorrow';
+import { ShowEntryForYesterdayCommand } from '../features/entries/commands/show-entry-for-yesterday';
+import { ShowNoteCommand } from '../features/notes/commands/show-note';
+import { WeeklyEntryWatcher } from '../features/weekly/weekly-entry-watcher';
+import { SyncDailyLinks } from '../features/weekly/sync-daily-links';
+import { SyncNoteLinks } from '../features/notes/sync-note-links';
+import { CompletedTaskActions } from '../features/tasks/codeactions/for-completed-tasks';
+import { OpenTaskActions } from '../features/tasks/codeactions/for-open-tasks';
 
 const MARKDOWN_SELECTOR: vscode.DocumentSelector = { scheme: 'file', language: 'markdown' };
 

src/app/startup.ts

@@ -20,8 +20,8 @@
 
 import * as vscode from 'vscode';
 import * as Path from 'path';
-import { isNullOrUndefined, ConsoleLogger } from '../util';
-import { Configuration } from '../vscode/conf';
+import { isNullOrUndefined, ConsoleLogger } from '../shared/index';
+import { Configuration } from '../shared/config/configuration';
 import { Container } from './container';
 import { registerCacheInvalidation, registerCodeActions, registerCommands } from './register';
 

src/commands/index.ts

@@ -20,8 +20,8 @@
 
 
 import * as vscode from 'vscode';
-import { Configuration } from './vscode';
-import { Startup } from './app';
+import { Configuration } from './shared/config/configuration';
+import { Startup } from './app/index';
 
 export var journalStartup: Startup;
 export var journalConfiguration: Configuration;

src/extension.ts

@@ -18,11 +18,10 @@
 'use strict';
 
 import * as vscode from 'vscode';
-import { LoadNotes } from '../features';
-import { JournalController, Input } from '../model';
-import { NoteInput, SelectedInput, ScopedTemplate } from '../model';
-import { getWeekFromURIAndConfig, isRemoteSession, toLocalFileUri } from '../journal/paths';
-import { SyncDailyLinks } from '../features/sync/sync-daily-links';
+import { LoadNotes } from '../../notes/load-note';
+import { JournalController, Input } from '../../../shared/model/index';
+import { NoteInput, SelectedInput, ScopedTemplate } from '../../../shared/model/index';
+import { isRemoteSession, toLocalFileUri } from '../../../shared/paths';
 
 
 export class AbstractLoadEntryForDateCommand implements vscode.Disposable {
@@ -131,17 +130,8 @@ export class AbstractLoadEntryForDateCommand implements vscode.Disposable {
             return this.ctrl.reader.loadEntryForInput(input)
                 .then((doc: vscode.TextDocument) => this.ctrl.inject.injectInput(doc, input))
                 .then((doc: vscode.TextDocument) => {
-                    // Fire-and-forget weekly sync — must never reject loadPageForInput.
-                    getWeekFromURIAndConfig(doc.uri, this.ctrl.config)
-                        .then(weekInfo => {
-                            if (weekInfo && this.ctrl.config.getWeeklySyncConfig().enabled) {
-                                const scopeId = weekInfo.scope === 'default' ? undefined : weekInfo.scope;
-                                new SyncDailyLinks(this.ctrl)
-                                    .sync(doc, weekInfo.week, weekInfo.year, scopeId)
-                                    .catch(err => this.ctrl.logger.error("loadPageForInput: weekly sync failed:", err));
-                            }
-                        })
-                        .catch(err => this.ctrl.logger.error("loadPageForInput: getWeekFromURIAndConfig failed:", err));
+                    // Notify other features (e.g. weekly daily-link sync) without importing them.
+                    this.ctrl.events.fireEntryOpened({ doc });
                     return doc;
                 });
         }

src/commands/show-entry-for-date.ts …/entries/commands/show-entry-for-date.tssrc/commands/show-entry-for-date.ts renamed to src/features/entries/commands/show-entry-for-date.ts src/commands/show-entry-for-date.ts renamed to src/features/entries/commands/show-entry-for-date.ts

@@ -18,7 +18,7 @@
 'use strict';
 
 import * as vscode from 'vscode';
-import { JournalController, Input } from '../model';
+import { JournalController, Input } from '../../../shared/model/index';
 import { AbstractLoadEntryForDateCommand } from './show-entry-for-date';
 
 

src/commands/show-entry-for-input.ts …entries/commands/show-entry-for-input.tssrc/commands/show-entry-for-input.ts renamed to src/features/entries/commands/show-entry-for-input.ts src/commands/show-entry-for-input.ts renamed to src/features/entries/commands/show-entry-for-input.ts

@@ -18,7 +18,7 @@
 'use strict';
 
 import * as vscode from 'vscode';
-import { JournalController, Input } from '../model';
+import { JournalController, Input } from '../../../shared/model/index';
 import { AbstractLoadEntryForDateCommand } from './show-entry-for-date';
 
 

src/commands/show-entry-for-today.ts …entries/commands/show-entry-for-today.tssrc/commands/show-entry-for-today.ts renamed to src/features/entries/commands/show-entry-for-today.ts src/commands/show-entry-for-today.ts renamed to src/features/entries/commands/show-entry-for-today.ts

@@ -18,7 +18,7 @@
 'use strict';
 
 import * as vscode from 'vscode';
-import { JournalController, Input } from '../model';
+import { JournalController, Input } from '../../../shared/model/index';
 import { AbstractLoadEntryForDateCommand } from './show-entry-for-date';
 
 

src/commands/show-entry-for-tomorrow.ts …ries/commands/show-entry-for-tomorrow.tssrc/commands/show-entry-for-tomorrow.ts renamed to src/features/entries/commands/show-entry-for-tomorrow.ts src/commands/show-entry-for-tomorrow.ts renamed to src/features/entries/commands/show-entry-for-tomorrow.ts

@@ -18,7 +18,7 @@
 'use strict';
 
 import * as vscode from 'vscode';
-import { JournalController, Input } from '../model';
+import { JournalController, Input } from '../../../shared/model/index';
 import { AbstractLoadEntryForDateCommand } from './show-entry-for-date';