fix(model): rename JournalPageType.attachement to attachment

[pajoma]

Problem (Domain Model Distortion)

The JournalPageType enum uses the misspelled member attachement (with an extra 'e'). This typo has leaked into multiple files and comments across the codebase.

Consequence

Code that mismatches standard language forces mental translation and increases cognitive load. Maintaining typos in the core domain model makes the codebase feel unpolished and can lead to confusion during search/replace operations.

Remedy

Rename JournalPageType.attachement to JournalPageType.attachment across the entire project.

In Scope

• Update enum definition in src/model/config.ts
• Update all consumers (e.g., src/journal/paths.ts, src/features/entries/scan-entries.ts)
• Update all test files and assertions
• Update documentation and comments

Related

• Identified during review of Refactor: Decouple inferType from raw patterns (R2) #199 / refactor(paths): decouple inferType from raw positional args (#199) #220

[pajoma]

Spec

Goal: Rename JournalPageType.attachement to JournalPageType.attachment across the entire codebase.

Why now: The typo is in the core domain model enum. Identified during #199/#220 review. Fixing before more consumers land minimises blast radius — all current consumers are known and enumerable.

In scope:

• Enum definition in src/model/config.ts
• All consumers: src/journal/paths.ts, src/vscode/dialogues.ts
• Inline comments in src/features/entries/scan-entries.ts
• Plan prose in docs/plans/2026-05-18-199-infer-type-context-object.md

Out of scope:

• Other worktrees (they rebase on develop after this lands)
• No config schema or serialisation changes — enum is in-process only

Acceptance:

1. grep -rn "attachement" src/ returns zero hits
2. TypeScript compilation succeeds
3. All existing tests pass

Related: Identified during #199, #220

Detail: docs/specs/2026-05-18-221-fix-attachement-typo.md

[pajoma]

Critical Review of Specification for Issue #221

The goal to eliminate this domain model distortion is correct, but the "In Scope" table is incomplete based on a codebase search. To ensure a "Fact-Based Fix" that truly removes the typo, the following must be added:

1. Missing Logic Renames (High Priority)

The spec misses a significant method rename that carries the typo:

• SyncNoteLinks.injectAttachementLinks: This method in src/features/sync/sync-note-links.ts must be renamed to injectAttachmentLinks.
• Startup.registerCommands: The call site in src/vscode/startup.ts (line 101) must be updated accordingly.

2. Missing Log Messages and Comments

Several internal strings and comments were omitted:

• src/features/sync/sync-note-links.ts: Lines 21, 22, 36, 41 contain logs and comments like injectAttachementLinks() - File link not present....
• src/vscode/dialogues.ts: Line 460 contains a switch case for the enum which was noted, but the icon display logic also uses the term.

3. Scope Expansion Recommendation

Since this lands on develop, the plan should explicitly include updating the generated plan files from recent tasks (like #199) that were used as base-text for this search. This prevents new tasks from accidentally re-introducing the typo via copy-paste.

Verdict: I recommend updating the specification to include the SyncNoteLinks and Startup modules before proceeding. A pure enum rename without fixing the method names that depend on it leaves the codebase in an inconsistent state (Accidental Complexity).

[pajoma]

Spec (Revised)

Spec updated based on review feedback. Complete scope now:

Goal: Eliminate every occurrence of the misspelled token attachement — enum member, method name, log strings, comments, and plan prose.

In scope (added vs v1):

• src/features/sync/sync-note-links.ts — method rename injectAttachementLinks → injectAttachmentLinks + 3 log strings on lines 22, 36, 41
• src/vscode/startup.ts:101 — call site updated accordingly

Full scope (all files):

• src/model/config.ts:4 — enum member
• src/journal/paths.ts:179 — return value + comment
• src/features/entries/scan-entries.ts:57,92 — comments
• src/vscode/dialogues.ts:129,130,460 — enum references
• src/features/sync/sync-note-links.ts:21,22,36,41 — method + logs
• src/vscode/startup.ts:101 — call site
• docs/plans/2026-05-18-199-infer-type-context-object.md:20,83 — plan prose

Acceptance: grep -rn "attachement" src/ returns zero hits; compilation succeeds; all tests pass.

Detail: docs/specs/2026-05-18-221-fix-attachement-typo.md

Please drop approved on the issue to proceed to the plan.

[pajoma]

Reviewer Approval of Revised Specification

The revised specification successfully incorporates all missing elements from the initial critical review.

Improvements:

• Method Rename: Including SyncNoteLinks.injectAttachmentLinks correctly addresses the leakage of the typo into the logic layer.
• Startup Sync: Updating the call site in startup.ts ensures the application continues to initialize correctly.
• Documentation Integrity: Explicitly including plan files from recent tasks prevents regression via copy-paste.

The scope is now comprehensive and technically rigorous. Approved. Proceed with the implementation plan.

[pajoma]

Plan

Approach: Single-commit rename across all affected files. TypeScript compiler enforces completeness — any missed reference fails to compile. One commit keeps git bisect attribution clean.

Steps:

1. Rename enum member in src/model/config.ts — compiler immediately flags unresolved consumers
2. Fix 5 enum consumer references in src/journal/paths.ts and src/vscode/dialogues.ts
3. Rename method signature + fix 3 log strings in src/features/sync/sync-note-links.ts
4. Fix call site in src/vscode/startup.ts
5. Fix inline comments in src/features/entries/scan-entries.ts
6. Fix plan prose in docs/plans/2026-05-18-199-infer-type-context-object.md (prevents copy-paste regression)
7. Verify: tsc --noEmit passes + grep -rn "attachement" src/ returns zero hits
8. Single commit + PR

Test scenarios:

• Compilation succeeds with zero TS errors
• grep -rn "attachement" src/ returns zero hits
• All existing tests pass unchanged

Dependencies: None — self-contained rename.

Risk: Active worktrees diverge temporarily; they rebase on develop after landing. Compiler surfaces any conflicts immediately on rebase.

Detail: docs/plans/2026-05-18-221-fix-attachement-typo.md

Please drop approved to proceed to implementation.

[pajoma]

Reviewer Approval of Implementation Plan

The implementation plan for issue #221 is comprehensive and technically sound.

Strengths:

• Compiler-Driven Integrity: Leveraging TypeScript compilation errors as a feedback loop for identifying enum consumers is a robust strategy.
• Method Signature Correction: Renaming injectAttachementLinks to injectAttachmentLinks correctly addresses the logic-layer leakage.
• Documentation Hygiene: Including plan files from related tasks (Refactor: Decouple inferType from raw patterns (R2) #199) ensures the fix is durable against future copy-paste regressions.

Final Skeptical Check:

• Search Confirmation: After completion, ensure grep -rn "attachement" src/ includes hidden files and directories if applicable, though the current scope seems sufficient.
• Log Precision: Verify that the 3 log strings in sync-note-links.ts are updated to match the new method name exactly for traceability.

The plan is approved. Proceed with implementation.

[pajoma]

PR #222 opens — implementing approved plan.