Skip to content

Commit 4e07553

Browse files
Unpend testing around cached buildpack in offline environment
[#166687251]
1 parent d65ee88 commit 4e07553

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

integration/init_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ func TestIntegration(t *testing.T) {
2020
Expect := NewWithT(t).Expect
2121

2222
var err error
23+
var nodeRepo string
2324
bpDir, err = dagger.FindBPRoot()
2425
Expect(err).NotTo(HaveOccurred())
2526

@@ -35,7 +36,7 @@ func TestIntegration(t *testing.T) {
3536
Expect(err).ToNot(HaveOccurred())
3637
defer dagger.DeleteBuildpack(nodeURI)
3738

38-
nodeRepo, err := dagger.GetLatestUnpackagedBuildpack("node-engine-cnb")
39+
nodeRepo, err = dagger.GetLatestUnpackagedBuildpack("node-engine-cnb")
3940
Expect(err).ToNot(HaveOccurred())
4041
defer os.RemoveAll(nodeRepo)
4142

integration/integration_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func testIntegration(t *testing.T, when spec.G, it spec.S) {
2222
var (
2323
Expect func(interface{}, ...interface{}) Assertion
2424
app *dagger.App
25-
err error
25+
err error
2626
)
2727

2828
it.Before(func() {
@@ -51,9 +51,7 @@ func testIntegration(t *testing.T, when spec.G, it spec.S) {
5151
Expect(body).To(ContainSubstring("Hello, World!"))
5252
})
5353

54-
// TODO: This test is blocked on a pack release https://www.pivotaltracker.com/story/show/169012540
55-
// unpend this test when the --network flag is in a pack release
56-
when.Pend("the npm and node buildpacks are cached", func() {
54+
when("the npm and node buildpacks are cached", func() {
5755
it("should not reach out to the internet", func() {
5856
app, err = dagger.NewPack(
5957
filepath.Join("testdata", "vendored"),

0 commit comments

Comments
 (0)