Skip to content

Commit 620bcea

Browse files
Remove buildpack.toml, in favor of buildpack.toml.tmpl
- Use go templating (./scripts/template.go) to construct the buildpack.toml when packaging/releasing cnbs - The CHANGELOG is deprecated, in favor of release notes - Use dagger.DeleteBuildpack to preserve built CNB in our release pipeline [#166793497]: Co-authored-by: David Freilich <dfreilich@pivotal.io>
1 parent 5f67b77 commit 620bcea

4 files changed

Lines changed: 4 additions & 47 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@
44
*.tgz
55
npm-cnb_*
66
bin/
7+
/buildpack.toml

CHANGELOG

Lines changed: 0 additions & 43 deletions
This file was deleted.

buildpack.toml renamed to buildpack.toml.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
[buildpack]
33
id = "org.cloudfoundry.npm"
44
name = "NPM Buildpack"
5-
version = "0.0.9"
5+
version = "{{ .Version }}"
66

77
[metadata]
88
include_files = ["bin/build","bin/detect","buildpack.toml"]

integration/integration_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package integration_test
22

33
import (
4-
"os"
54
"path/filepath"
65
"testing"
76

@@ -30,11 +29,11 @@ func TestIntegration(t *testing.T) {
3029
Expect(err).NotTo(HaveOccurred())
3130
npmURI, err = dagger.PackageBuildpack(bpDir)
3231
Expect(err).ToNot(HaveOccurred())
33-
defer os.RemoveAll(npmURI)
32+
defer dagger.DeleteBuildpack(npmURI)
3433

3534
nodeURI, err = dagger.GetLatestBuildpack("node-engine-cnb")
3635
Expect(err).ToNot(HaveOccurred())
37-
defer os.RemoveAll(nodeURI)
36+
defer dagger.DeleteBuildpack(nodeURI)
3837

3938
suite.Run(t)
4039
}

0 commit comments

Comments
 (0)