Skip to content

Commit e7fd3ad

Browse files
Makes start command compatible with new libbuildpack
[#168418587]
1 parent 438a576 commit e7fd3ad

37 files changed

Lines changed: 40 additions & 9250 deletions

File tree

go.mod

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@ go 1.12
44

55
require (
66
github.com/Masterminds/semver v1.4.2
7-
github.com/buildpack/libbuildpack v1.23.0
7+
github.com/buildpack/libbuildpack v1.24.0
88
github.com/cloudfoundry/dagger v0.0.0-20190910211006-e7385ebe12c4
99
github.com/cloudfoundry/libcfbuildpack v1.85.0
1010
github.com/golang/mock v1.3.1
1111
github.com/onsi/gomega v1.7.0
1212
github.com/sclevine/spec v1.2.0
13+
golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45 // indirect
14+
google.golang.org/appengine v1.6.2 // indirect
1315
)

go.sum

Lines changed: 0 additions & 107 deletions
This file was deleted.

modules/modules.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ func (c Contributor) Contribute() error {
9494
return err
9595
}
9696

97-
return c.launch.WriteApplicationMetadata(layers.Metadata{Processes: []layers.Process{{"web", "npm start"}}})
97+
return c.launch.WriteApplicationMetadata(layers.Metadata{Processes: []layers.Process{{"web", "npm start", false}}})
9898
}
9999

100100
func (c Contributor) contributeNodeModules(layer layers.Layer) error {

modules/modules_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ func testModules(t *testing.T, when spec.G, it spec.S) {
117117
Expect(filepath.Join(factory.Build.Application.Root, modules.ModulesDir)).NotTo(BeADirectory())
118118
Expect(filepath.Join(factory.Build.Application.Root, modules.CacheDir)).NotTo(BeADirectory())
119119

120-
Expect(factory.Build.Layers).To(test.HaveApplicationMetadata(layers.Metadata{Processes: []layers.Process{{"web", "npm start"}}}))
120+
Expect(factory.Build.Layers).To(test.HaveApplicationMetadata(layers.Metadata{Processes: []layers.Process{{"web", "npm start", false}}}))
121121

122122
nodeModulesMetadataName, _ := contributor.NodeModulesMetadata.Identity()
123123
npmCacheMetadataName, _ := contributor.NPMCacheMetadata.Identity()

0 commit comments

Comments
 (0)