Fix non-constant format string in call to packit.Fail.WithMessage

jericop · jericop · commit 0b72461920b6 · 2025-09-05T17:28:06.000-04:00
diff --git a/detect.go b/detect.go
@@ -1,7 +1,6 @@
 package pipinstall
 
 import (
-	"fmt"
 	"os"
 	"path/filepath"
 	"strings"
@@ -44,7 +43,7 @@ func Detect() packit.DetectFunc {
 		}
 
 		if !allRequirementsFilesExist {
-			return packit.DetectResult{}, packit.Fail.WithMessage(fmt.Sprintf("requirements file not found at: '%s'", strings.Join(missingRequirementFiles, "', '")))
+			return packit.DetectResult{}, packit.Fail.WithMessage("requirements file not found at: '%s'", strings.Join(missingRequirementFiles, "', '"))
 		}
 
 		return packit.DetectResult{

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,6 @@`
`1`	`1`	`package pipinstall`
`2`	`2`
`3`	`3`	`import (`
`4`		`- "fmt"`
`5`	`4`	`"os"`
`6`	`5`	`"path/filepath"`
`7`	`6`	`"strings"`
`@@ -44,7 +43,7 @@ func Detect() packit.DetectFunc {`
`44`	`43`	`}`
`45`	`44`
`46`	`45`	`if !allRequirementsFilesExist {`
`47`		`- return packit.DetectResult{}, packit.Fail.WithMessage(fmt.Sprintf("requirements file not found at: '%s'", strings.Join(missingRequirementFiles, "', '")))`
	`46`	`+ return packit.DetectResult{}, packit.Fail.WithMessage("requirements file not found at: '%s'", strings.Join(missingRequirementFiles, "', '"))`
`48`	`47`	`}`
`49`	`48`
`50`	`49`	`return packit.DetectResult{`