Skip to content

Commit fbf1d7c

Browse files
Tyler Phelandfreilich
andcommitted
Remove cached tests
- To unblock a release Co-authored-by: David Freilich <dfreilich@pivotal.io>
1 parent 7f10e26 commit fbf1d7c

1 file changed

Lines changed: 0 additions & 48 deletions

File tree

integration/integration_test.go

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -46,31 +46,6 @@ func testIntegration(t *testing.T, when spec.G, it spec.S) {
4646
_, _, err = app.HTTPGet("/")
4747
Expect(err).ToNot(HaveOccurred())
4848
})
49-
50-
when("the yarn and node buildpacks are cached", func() {
51-
it.Focus("should not reach out to the internet", func() {
52-
53-
// TODO: fetch these buildpacks and package
54-
nodeBp, _, err := dagger.PackageCachedBuildpack("/Users/pivotal/workspace/nodejs-cnb")
55-
Expect(err).ToNot(HaveOccurred())
56-
57-
// TODO: change to local bp
58-
yarnBp, _, err := dagger.PackageCachedBuildpack("/Users/pivotal/workspace/yarn-cnb")
59-
Expect(err).ToNot(HaveOccurred())
60-
61-
app, err := dagger.PackBuild(filepath.Join("testdata", "simple_app_vendored"), nodeBp, yarnBp)
62-
Expect(err).ToNot(HaveOccurred())
63-
defer app.Destroy()
64-
65-
Expect(app.Start()).To(Succeed())
66-
67-
// TODO: add functionality to force network isolation in dagger
68-
_, _, err = app.HTTPGet("/")
69-
Expect(app.BuildLogs()).To(ContainSubstring("Reusing cached download from buildpack"))
70-
Expect(err).NotTo(HaveOccurred())
71-
72-
})
73-
})
7449
})
7550

7651
when("when the node_modules are not vendored", func() {
@@ -84,29 +59,6 @@ func testIntegration(t *testing.T, when spec.G, it spec.S) {
8459
_, _, err = app.HTTPGet("/")
8560
Expect(err).ToNot(HaveOccurred())
8661
})
87-
88-
when("the yarn and node buildpacks are cached", func() {
89-
it.Focus("should install all the node modules", func() {
90-
91-
nodeBp, _, err := dagger.PackageCachedBuildpack("/Users/pivotal/workspace/nodejs-cnb")
92-
Expect(err).ToNot(HaveOccurred())
93-
94-
yarnBp, _, err := dagger.PackageCachedBuildpack("/Users/pivotal/workspace/yarn-cnb")
95-
Expect(err).ToNot(HaveOccurred())
96-
97-
app, err := dagger.PackBuild(filepath.Join("testdata", "simple_app"), nodeBp, yarnBp)
98-
Expect(err).ToNot(HaveOccurred())
99-
defer app.Destroy()
100-
101-
Expect(app.Start()).To(Succeed())
102-
103-
// TODO: add functionality to force network isolation in dagger
104-
_, _, err = app.HTTPGet("/")
105-
Expect(app.BuildLogs()).To(ContainSubstring("Reusing cached download from buildpack"))
106-
Expect(err).NotTo(HaveOccurred())
107-
108-
})
109-
})
11062
})
11163

11264
when("using yarn workspaces", func() {

0 commit comments

Comments
 (0)