Skip to content

Commit 2c872f6

Browse files
asvobodabluekeyes
authored andcommitted
Revert "Use in-memory http caching" (#127)
The current cache implementation has some issues with both authenticated requests and freshness of data, so reverting it while we work on improvements. This reverts commit 5bebbba.
1 parent 5bebbba commit 2c872f6

6 files changed

Lines changed: 2 additions & 590 deletions

File tree

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@
33
*.iml
44
*.ipr
55
*.iws
6-
config/bulldozer.yml
76

87
build/

Gopkg.lock

Lines changed: 2 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

server/server.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ package server
1717
import (
1818
"fmt"
1919

20-
"github.com/gregjones/httpcache"
2120
"github.com/palantir/go-baseapp/baseapp"
2221
"github.com/palantir/go-baseapp/baseapp/datadog"
2322
"github.com/palantir/go-githubapp/githubapp"
@@ -54,7 +53,6 @@ func New(c *Config) (*Server, error) {
5453
c.Github,
5554
githubapp.WithClientUserAgent(userAgent),
5655
githubapp.WithClientMiddleware(
57-
githubapp.ClientCaching(func() httpcache.Cache { return httpcache.NewMemoryCache() }),
5856
githubapp.ClientLogging(zerolog.DebugLevel),
5957
githubapp.ClientMetrics(base.Registry()),
6058
),

vendor/github.com/gregjones/httpcache/LICENSE.txt

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)