Remove unused function, run 'go fix' again

Author: bluekeyes

bulldozer/evaluate_test.go

@@ -872,8 +872,3 @@ func TestShouldUpdatePR(t *testing.T) {
 		})
 	}
 }
-
-//go:fix inline
-func boolVal(b bool) *bool {
-	return new(b)
-}

bulldozer/update.go

@@ -54,8 +54,8 @@ func UpdatePR(ctx context.Context, pullCtx pull.Context, client *github.Client,
 
 	logger.Debug().Msg("Pull request is not up to date, attempting an update")
 	mergeCommit, _, err := client.Repositories.Merge(ctx, pullCtx.Owner(), pullCtx.Repo(), &github.RepositoryMergeRequest{
-		Base: github.Ptr(pr.Head.GetRef()),
-		Head: github.Ptr(baseRef),
+		Base: new(pr.Head.GetRef()),
+		Head: new(baseRef),
 	})
 	if err != nil {
 		logger.Error().Err(errors.WithStack(err)).Msg("Update merge failed unexpectedly")

pull/pull_requests_test.go

@@ -47,8 +47,8 @@ func TestGetOpenPullRequestsForSHA(t *testing.T) {
 	sha := "sha"
 
 	pr := &github.PullRequest{
-		State: github.Ptr("open"),
-		Head:  &github.PullRequestBranch{SHA: github.Ptr(sha)},
+		State: new("open"),
+		Head:  &github.PullRequestBranch{SHA: new(sha)},
 	}
 
 	mockClient.On("ListPullRequestsWithCommit", ctx, owner, repo, sha, mock.Anything).Return([]*github.PullRequest{pr}, &github.Response{NextPage: 0}, nil)
@@ -69,8 +69,8 @@ func TestListOpenPullRequestsForSHA(t *testing.T) {
 	sha := "sha"
 
 	pr := &github.PullRequest{
-		State: github.Ptr("open"),
-		Head:  &github.PullRequestBranch{SHA: github.Ptr(sha)},
+		State: new("open"),
+		Head:  &github.PullRequestBranch{SHA: new(sha)},
 	}
 
 	mockClient.On("List", ctx, owner, repo, mock.Anything).Return([]*github.PullRequest{pr}, &github.Response{NextPage: 0}, nil)
@@ -91,8 +91,8 @@ func TestGetAllPossibleOpenPullRequestsForSHA_FirstMethodReturnsResults(t *testi
 	sha := "sha"
 
 	pr := &github.PullRequest{
-		State: github.Ptr("open"),
-		Head:  &github.PullRequestBranch{SHA: github.Ptr(sha)},
+		State: new("open"),
+		Head:  &github.PullRequestBranch{SHA: new(sha)},
 	}
 
 	// Mock the first method to return a valid pull request.
@@ -116,8 +116,8 @@ func TestGetAllPossibleOpenPullRequestsForSHA_SecondMethodReturnsResults(t *test
 	sha := "sha"
 
 	pr := &github.PullRequest{
-		State: github.Ptr("open"),
-		Head:  &github.PullRequestBranch{SHA: github.Ptr(sha)},
+		State: new("open"),
+		Head:  &github.PullRequestBranch{SHA: new(sha)},
 	}
 
 	// Mock the first method to return no results.
@@ -178,8 +178,8 @@ func TestListOpenPullRequestsForRef(t *testing.T) {
 	ref := "refs/heads/main"
 
 	pr := &github.PullRequest{
-		State: github.Ptr("open"),
-		Base:  &github.PullRequestBranch{Ref: github.Ptr("main")},
+		State: new("open"),
+		Base:  &github.PullRequestBranch{Ref: new("main")},
 	}
 
 	mockClient.On("List", ctx, owner, repo, mock.Anything).Return([]*github.PullRequest{pr}, &github.Response{NextPage: 0}, nil)

server/handler/push.go

@@ -46,9 +46,9 @@ func (h *Push) Handle(ctx context.Context, eventType, deliveryID string, payload
 
 	// todo: fixup PushEventRepository != Repository
 	ghRepo := &github.Repository{
-		Name: github.Ptr(repoName),
+		Name: new(repoName),
 		Owner: &github.User{
-			Login: github.Ptr(owner),
+			Login: new(owner),
 		},
 	}