Publish docker containers (#6)

* Remove select statement

* Persist client/build directory

Author: ungureanuvladvictor

.circleci/config.yml

@@ -91,6 +91,10 @@ jobs:
           paths:
             - ./client/node_modules
           key: v1-dependencies-{{ checksum "./client/package.json" }}
+      - persist_to_workspace:
+          root: /go/src/github.com/palantir/bulldozer
+          paths:
+            - client/build
       - *store-test-results
 
   changelog:
@@ -111,6 +115,8 @@ jobs:
       - *install-docker-client
       - run: ./godelw publish bintray --url https://api.bintray.com --subject palantir --repository releases --user "$BINTRAY_USERNAME" --password "$BINTRAY_PASSWORD" --publish --downloads-list bulldozer
       - run: sha256sum dist/*.tgz
+      - attach_workspace:
+          at: /go/src/github.com/palantir/bulldozer
       - *build-docker-image
       - run: ./publish-docker.sh
 

github/github.go

@@ -398,9 +398,7 @@ func (client *Client) PullRequestForSHA(repo *github.Repository, SHA string) (*g
 
 	ticker := time.NewTicker(5 * time.Second)
 	for {
-		select {
-		case <-ticker.C:
-		}
+		<-ticker.C
 
 		// polling for merge status (https://developer.github.com/v3/pulls/#get-a-single-pull-request)
 		p, _, err := client.PullRequests.Get(client.Ctx, owner, name, pullRequest.GetNumber())