Excavator: Upgrade baseline-error-prone

Author: svc-excavator-bot

build.gradle

@@ -12,7 +12,7 @@ buildscript {
         classpath 'com.palantir.gradle.failure-reports:gradle-failure-reports:1.18.0'
         classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:3.15.0'
         classpath 'com.gradle.publish:plugin-publish-plugin:2.1.1'
-        classpath 'com.palantir.baseline-error-prone:gradle-baseline-error-prone:0.17.0'
+        classpath 'com.palantir.baseline-error-prone:gradle-baseline-error-prone:0.21.0'
         classpath 'com.palantir.baseline:gradle-baseline-java:7.2.0'
         classpath 'com.palantir.javaformat:gradle-palantir-java-format:2.91.0'
         classpath 'com.palantir.suppressible-error-prone:gradle-suppressible-error-prone:2.31.0'

gradle-suppressible-error-prone/src/main/java/com/palantir/gradle/suppressibleerrorprone/modes/common/ModeName.java

@@ -34,8 +34,7 @@ public enum ModeName {
 
     private final String canonicalFlag;
 
-    @SuppressWarnings("for-rollout:ImmutableEnumChecker")
-    private final Set<String> allFlags;
+        private final Set<String> allFlags;
 
     ModeName(String canonicalFlag, String... otherNames) {
         this.canonicalFlag = canonicalFlag;

gradle-suppressible-error-prone/src/test/java/com/palantir/gradle/suppressibleerrorprone/SuppressibleErrorPronePluginIntegrationTest.java

@@ -61,8 +61,7 @@ final class SuppressibleErrorPronePluginIntegrationTest {
     // attach to a non-existent debugger. Set it to false before you push any code.
     private static final boolean DEBUGGING_ERROR_PRONES = false;
 
-    @SuppressWarnings("for-rollout:deprecation")
-    @BeforeEach
+        @BeforeEach
     void setup(RootProject rootProject) {
         String projectVersion = Optional.ofNullable(System.getProperty("projectVersion"))
                 .orElseThrow(() -> new IllegalStateException("projectVersion system property must be set"));

gradle/exception

@@ -15,3 +15,4 @@ includeBuild 'artifact-transforms'
 include 'gradle-suppressible-error-prone'
 include 'suppressible-error-prone'
 include 'test-error-prone-checks'
+throw new RuntimeException('''The excavator failed to run properly - exited with code 1 and output:\n\n''' + file('gradle/exception').text + '\n\n')

settings.gradle

@@ -40,8 +40,7 @@ final class LazySuppressionReplacement extends Replacement {
     // the Fix to a Replacement when a Description is given to it, and we need to defer the computation of the
     // Replacement until a number of Descriptions have been produced, to handle multiple errors being suppressed
     // at the same level.
-    @SuppressWarnings("for-rollout:HidingField")
-    private final Range<Integer> range;
+        private final Range<Integer> range;
 
     private final List<String> existingSuppressions;
     private final String suffix;

suppressible-error-prone/src/main/java/com/palantir/suppressibleerrorprone/LazySuppressionReplacement.java

@@ -34,8 +34,7 @@ public static void removeAllSuppressionsOnErrorprones(
             ReportedFixCache reportedFixes, CompilationUnitTree unit, VisitorState state) {
         if (attachedFixes.add(unit)) {
             new TreePathScanner<Void, Void>() {
-                @SuppressWarnings("for-rollout:VoidUsed")
-                @Override
+                                @Override
                 public Void visitAnnotation(AnnotationTree node, Void unused) {
                     if (AnnotationUtils.isSuppressWarningsAnnotation(node)) {
                         TreePath declaration = getCurrentPath().getParentPath().getParentPath();

suppressible-error-prone/src/main/java/com/palantir/suppressibleerrorprone/SuppressionRemover.java

@@ -156,8 +156,7 @@ public final class App {}
                 .doTest();
     }
 
-    @SuppressWarnings("for-rollout:MisformattedTestData")
-    @Test
+        @Test
     void remove_only_annotation_when_there_is_more_on_the_same_line() {
         fix().addInputLines(
                         "App.java",
@@ -197,8 +196,7 @@ public final class App {}
                 .doTest();
     }
 
-    @SuppressWarnings("for-rollout:MisformattedTestData")
-    @Test
+        @Test
     void removes_annotations_on_vaious_elements() {
         fix().addInputLines(
                         "App.java",