fix: icons that may not appear due to blocking main thread

chore: some code cleanup

Author: CLARATION

Loader/AppDelegate.swift

@@ -19,15 +19,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
 	// MARK: UISceneSession Lifecycle
 
 	func application(_ application: UIApplication, configurationForConnecting connectingSceneSession: UISceneSession, options: UIScene.ConnectionOptions) -> UISceneConfiguration {
-		// Called when a new scene session is being created.
-		// Use this method to select a configuration to create the new scene with.
-		return UISceneConfiguration(name: "Default Configuration", sessionRole: connectingSceneSession.role)
-	}
-
-	func application(_ application: UIApplication, didDiscardSceneSessions sceneSessions: Set<UISceneSession>) {
-		// Called when the user discards a scene session.
-		// If any sessions were discarded while the application was not running, this will be called shortly after application:didFinishLaunchingWithOptions.
-		// Use this method to release any resources that were specific to the discarded scenes, as they will not return.
+		UISceneConfiguration(name: "Default Configuration", sessionRole: connectingSceneSession.role)
 	}
 
 	func applicationWillTerminate(_ application: UIApplication) {

Loader/Extensions/UIDevice/UIDevice+Info.swift

@@ -27,12 +27,12 @@ extension UIDevice {
 
 	/// The devices architecture (e.g. arm64).
 	var architecture: String {
-		return String(cString: NXGetLocalArchInfo().pointee.name)
+		String(cString: NXGetLocalArchInfo().pointee.name)
 	}
 
 	/// The devices marketing model (e.g. iPhone 7)
 	var marketingModel: String {
-		return MGCopyAnswer(kMGPhysicalHardwareNameString)?.takeUnretainedValue() as? String ?? "Unknown"
+		MGCopyAnswer(kMGPhysicalHardwareNameString)?.takeUnretainedValue() as? String ?? "Unknown"
 	}
 
 	var kernelVersion: String {

Loader/Extensions/UIDevice/UIDevice+Jailbreak.swift

@@ -24,7 +24,7 @@ extension UIDevice {
 
 		/// See flags in string format
 		var flags: String {
-			return String(format: "0x%llx", LREnvironment.jbd.getFlags())
+			String(format: "0x%llx", LREnvironment.jbd.getFlags())
 		}
 		/// See flags in a string-list format
 		var flagsList: String {

Loader/SceneDelegate.swift

@@ -8,7 +8,6 @@
 import UIKit
 
 class SceneDelegate: UIResponder, UIWindowSceneDelegate {
-
 	var window: UIWindow?
 
 	func scene(_ scene: UIScene, willConnectTo session: UISceneSession, options connectionOptions: UIScene.ConnectionOptions) {
@@ -26,35 +25,5 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {
 		window.makeKeyAndVisible()
 		self.window = window
 	}
-
-	func sceneDidDisconnect(_ scene: UIScene) {
-		// Called as the scene is being released by the system.
-		// This occurs shortly after the scene enters the background, or when its session is discarded.
-		// Release any resources associated with this scene that can be re-created the next time the scene connects.
-		// The scene may re-connect later, as its session was not necessarily discarded (see `application:didDiscardSceneSessions` instead).
-	}
-
-	func sceneDidBecomeActive(_ scene: UIScene) {
-		// Called when the scene has moved from an inactive state to an active state.
-		// Use this method to restart any tasks that were paused (or not yet started) when the scene was inactive.
-	}
-
-	func sceneWillResignActive(_ scene: UIScene) {
-		// Called when the scene will move from an active state to an inactive state.
-		// This may occur due to temporary interruptions (ex. an incoming phone call).
-	}
-
-	func sceneWillEnterForeground(_ scene: UIScene) {
-		// Called as the scene transitions from the background to the foreground.
-		// Use this method to undo the changes made on entering the background.
-	}
-
-	func sceneDidEnterBackground(_ scene: UIScene) {
-		// Called as the scene transitions from the foreground to the background.
-		// Use this method to save data, release shared resources, and store enough scene-specific state information
-		// to restore the scene back to its current state.
-	}
-
-
 }
 

Loader/Utilities/Config/Models/LRConfig.swift

@@ -131,17 +131,24 @@ struct LRManager: Codable {
 	/// Package manager image representation uri
 	let icon: URL
 	/// Package manager install path
-	/// Useful for detecting if it is installed, due to them having a common path we're able to keep track of
 	let filePath: URL
 
-	func loadIconImage() -> UIImage {
-		guard
-			let data = try? Data(contentsOf: icon),
-			let image = UIImage(data: data)
-		else {
-			return UIImage(named: "unknown")!
-		}
-		return image
+	/// Asynchronously load the icon image
+	func loadIconImage(completion: @escaping (UIImage) -> Void) {
+		URLSession.shared.dataTask(with: icon) { data, response, error in
+			if 
+				let data = data,
+				let image = UIImage(data: data)
+			{
+				DispatchQueue.main.async {
+					completion(image)
+				}
+			} else {
+				DispatchQueue.main.async {
+					completion(UIImage(named: "unknown")!)
+				}
+			}
+		}.resume()
 	}
 }
 

Loader/Views/Selection/LRBootstrapViewController.swift

@@ -149,7 +149,11 @@ extension LRBootstrapViewController {
 
 		cell.textLabel?.text = manager?.name
 		cell.accessoryType = .disclosureIndicator
-		cell.setSectionImage(with: manager?.loadIconImage() ?? UIImage(named: "unknown")!)
+		cell.setSectionImage(with: UIImage(named: "unknown")!)
+		
+		manager?.loadIconImage { image in
+			cell.setSectionImage(with: image)
+		}
 
 		return cell
 	}

Loader/Views/Settings/Credits/LRSettingsCreditsViewController.swift

@@ -74,15 +74,15 @@ class LRSettingsCreditsViewController: LRBaseTableViewController {
 // MARK: - Class extension: tableview
 extension LRSettingsCreditsViewController {
 	override func numberOfSections(in tableView: UITableView) -> Int {
-		return _data.count
+		_data.count
 	}
 
 	override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
-		return _data[section].data.count
+		_data[section].data.count
 	}
 
 	override func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {
-		return _data[section].name
+		_data[section].name
 	}
 
 	override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {

Loader/Views/Settings/LRSettingsViewController.swift

@@ -102,7 +102,7 @@ class LRSettingsViewController: LRBaseStructuredTableViewController {
 								}
 							}
 
-							var style: UIAlertController.Style = UIDevice.current.userInterfaceIdiom == .pad
+							let style: UIAlertController.Style = UIDevice.current.userInterfaceIdiom == .pad
 							? .alert
 							: .actionSheet