Skip to content

Commit 8704f86

Browse files
authored
Merge pull request #172 from bdrung/isoformat
test: use isoformat() to compare dates with timezone information
2 parents 419fee9 + 1dd3562 commit 8704f86

1 file changed

Lines changed: 15 additions & 25 deletions

File tree

src/croniter/tests/test_croniter.py

Lines changed: 15 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -801,37 +801,29 @@ def test_std_dst(self):
801801
# -> 2017-03-26 01:59+1:00 -> 03:00+2:00
802802
local_date = tz.localize(datetime(2017, 3, 26))
803803
val = croniter("0 0 * * *", local_date).get_next(datetime)
804-
self.assertEqual(val, tz.localize(datetime(2017, 3, 27)))
804+
self.assertEqual(val.isoformat(), "2017-03-27T00:00:00+02:00")
805805
#
806806
local_date = tz.localize(datetime(2017, 3, 26, 1))
807807
cr = croniter("0 * * * *", local_date)
808808
val = cr.get_next(datetime)
809-
self.assertEqual(val, tz.localize(datetime(2017, 3, 26, 3)))
809+
self.assertEqual(val.isoformat(), "2017-03-26T03:00:00+02:00")
810810
val = cr.get_current(datetime)
811-
self.assertEqual(val, tz.localize(datetime(2017, 3, 26, 3)))
811+
self.assertEqual(val.isoformat(), "2017-03-26T03:00:00+02:00")
812812

813813
# -> 2017-10-29 02:59+2:00 -> 02:00+1:00
814814
local_date = tz.localize(datetime(2017, 10, 29))
815815
val = croniter("0 0 * * *", local_date).get_next(datetime)
816-
self.assertEqual(val, tz.localize(datetime(2017, 10, 30)))
816+
self.assertEqual(val.isoformat(), "2017-10-30T00:00:00+01:00")
817817
local_date = tz.localize(datetime(2017, 10, 29, 1, 59))
818-
val = croniter("0 * * * *", local_date).get_next(datetime)
819-
self.assertEqual(
820-
val.replace(tzinfo=None),
821-
tz.localize(datetime(2017, 10, 29, 2)).replace(tzinfo=None),
822-
)
823-
local_date = tz.localize(datetime(2017, 10, 29, 2))
824-
val = croniter("0 * * * *", local_date).get_next(datetime)
825-
self.assertEqual(val, tz.localize(datetime(2017, 10, 29, 3)))
826-
local_date = tz.localize(datetime(2017, 10, 29, 3))
827-
val = croniter("0 * * * *", local_date).get_next(datetime)
828-
self.assertEqual(val, tz.localize(datetime(2017, 10, 29, 4)))
829-
local_date = tz.localize(datetime(2017, 10, 29, 4))
830-
val = croniter("0 * * * *", local_date).get_next(datetime)
831-
self.assertEqual(val, tz.localize(datetime(2017, 10, 29, 5)))
832-
local_date = tz.localize(datetime(2017, 10, 29, 5))
833-
val = croniter("0 * * * *", local_date).get_next(datetime)
834-
self.assertEqual(val, tz.localize(datetime(2017, 10, 29, 6)))
818+
cr = croniter("0 * * * *", local_date)
819+
schedule = [cr.get_next(datetime).isoformat() for _ in range(4)]
820+
expected_schedule = [
821+
"2017-10-29T02:00:00+02:00",
822+
"2017-10-29T02:00:00+01:00",
823+
"2017-10-29T03:00:00+01:00",
824+
"2017-10-29T04:00:00+01:00",
825+
]
826+
self.assertEqual(schedule, expected_schedule)
835827

836828
def test_std_dst2(self):
837829
"""
@@ -880,12 +872,10 @@ def test_std_dst3(self):
880872

881873
schedule = croniter("0 0 24 * *", tz.localize(datetime(2020, 4, 15)))
882874
val1 = schedule.get_prev(datetime)
883-
dt1 = tz.localize(datetime(2020, 3, 24))
884-
self.assertEqual(val1, dt1)
875+
self.assertEqual(val1.isoformat(), "2020-03-24T00:00:00+10:30")
885876

886877
val2 = schedule.get_next(datetime)
887-
dt2 = tz.localize(datetime(2020, 4, 24))
888-
self.assertEqual(val2, dt2)
878+
self.assertEqual(val2.isoformat(), "2020-04-24T00:00:00+09:30")
889879

890880
def test_error_alpha_cron(self):
891881
self.assertRaises(CroniterNotAlphaError, croniter.expand, "* * * janu-jun *")

0 commit comments

Comments
 (0)