Skip to content

Commit dfd324a

Browse files
committed
fix typing and styling
1 parent 79842ad commit dfd324a

1 file changed

Lines changed: 3 additions & 21 deletions

File tree

flask_admin/tests/sqla/test_basic.py

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3812,22 +3812,6 @@ class MyModelView(CustomModelView):
38123812
)
38133813

38143814

3815-
@pytest.mark.xfail(
3816-
reason="SQLALiteProvider does not support passing db.session directly",
3817-
raises=TypeError,
3818-
strict=True,
3819-
)
3820-
def test_sqlalite_session_raises(app: Flask, sqla_db_ext: T_ANY_SQLA_PROVIDER) -> None:
3821-
if sqla_db_ext.__class__.__name__ != "SQLALiteProvider":
3822-
pytest.skip("Only relevant for SQLALiteProvider")
3823-
3824-
Model, _ = create_models(sqla_db_ext)
3825-
with app.app_context():
3826-
sqla_db_ext.create_all()
3827-
3828-
ModelView(Model, sqla_db_ext.db.session) # type: ignore[arg-type]
3829-
3830-
38313815
@pytest.mark.parametrize(
38323816
"with_delete, modal", [(True, True), (True, False), (False, True), (False, False)]
38333817
)
@@ -3839,8 +3823,6 @@ def test_del_btn_in_edit_and_details(
38393823
with_delete: bool,
38403824
modal: bool,
38413825
) -> None:
3842-
3843-
38443826
with app.app_context():
38453827
Model1, Model2 = create_models(sqla_db_ext)
38463828
param = skip_or_return_session_or_db(sqla_db_ext, session_or_db)
@@ -3890,12 +3872,12 @@ class MyModelView(CustomModelView):
38903872
raises=TypeError,
38913873
strict=True,
38923874
)
3893-
def test_sqlalite_session_raises(app, sqla_db_ext):
3875+
def test_sqlalite_session_raises(app: Flask, sqla_db_ext: T_ANY_SQLA_PROVIDER) -> None:
38943876
if sqla_db_ext.__class__.__name__ != "SQLALiteProvider":
38953877
pytest.skip("Only relevant for SQLALiteProvider")
38963878

3897-
Model = create_models(sqla_db_ext)
3879+
Model, _ = create_models(sqla_db_ext)
38983880
with app.app_context():
38993881
sqla_db_ext.create_all()
39003882

3901-
ModelView(Model, sqla_db_ext.db.session)
3883+
ModelView(Model, sqla_db_ext.db.session) # type: ignore[arg-type]

0 commit comments

Comments
 (0)