Skip to content

uint16_t is too small for resistors #4

@brianjmurrell

Description

@brianjmurrell

1MOhm thermistors are not uncommon. 1,000,000 overflows a 16 bit unsigned int.

Bumping the resistor types up to uint32_t seems to fix the overflow.

While I'm bug reporting, is #define VERBOSE_SENSOR_ENABLED 1 really an appropriate default? That seems like something somebody should have to enable if they are debugging.

And finally, why do you return the temperature multiplied by 10?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions