[BUG] The definition of CL_BURN_POSITION action in ACTIONS_ABI in infinity-sdk is wrong

[gummy789j]

Is there an existing issue for this?

• I have searched the existing issues

Product

Other

Current Behavior

snippet from infinity-periphery

            } else if (action == Actions.CL_BURN_POSITION) {
                // Will automatically decrease liquidity to 0 if the position is not already empty.
                (uint256 tokenId, uint128 amount0Min, uint128 amount1Min, bytes calldata hookData) =
                    params.decodeCLBurnParams();
                _burn(tokenId, amount0Min, amount1Min, hookData);
                return;
            }

and I found the definition in CL_BURN_POSITION in ACTIONS_ABI is different

snippet from infinity-sdk

  // 0x03
  [ACTIONS.CL_BURN_POSITION]: parseAbiParameters([
    'uint256 tokenId, PositionConfig config, uint128 amount0Min, uint128 amount1Min, bytes hookData',
    ...ABI_STRUCT_POSITION_CONFIG,
  ]),

Expected Behavior

remove PositionConfig

  // 0x03
  [ACTIONS.CL_BURN_POSITION]: parseAbiParameters([
    'uint256 tokenId, uint128 amount0Min, uint128 amount1Min, bytes hookData',
    ...ABI_STRUCT_POSITION_CONFIG,
  ]),

Steps To Reproduce

checkout the infinity-periphery and infinity-sdk

Environment

no

Anything else?

No response

[nidemidovich]

Good day! I also ran into it. If there is no response from the development team, then I can take up the fix.

[memoyil]

@gummy789j @nidemidovich burn call currently not used in frontend (and probably shouldn't be), decreasing / removing liquidity done by 'CL_DECREASE_LIQUIDITY' call. Since burn call sends the nft to the burn address and which means the position would not be shown in the closed section in position page imho it is better to not use it to make user keep seeing their closed positions.

[nidemidovich]

@memoyil thanks for the answer! But what if I use the sdk to interact with pancake not only from frontend? Currently I'm building the software to interact with pancake, but I don't want to write my own contract

[memoyil]

@nidemidovich true, for the sdk users this is needed.

[nidemidovich]

@memoyil yes, at least I'm one of these users =)

could you please review PR then?

[nidemidovich]

@memoyil hello! Is there any updates?