merge ty_all and pyrefly_strict

Author: cmp0xff

.github/workflows/comment_commands.yml

@@ -16,7 +16,7 @@ jobs:
       actions: write
       checks: write
     # if more commands are added, they will need to be added here too as we don't have access to env at this stage
-    if: (github.event.issue.pull_request) && contains(fromJSON('["/pandas_nightly", "/mypy_nightly", "/pyrefly_strict", "/pyrefly_all", "/ty_all"]'), github.event.comment.body) && github.event.comment.author_association == 'MEMBER'
+    if: (github.event.issue.pull_request) && contains(fromJSON('["/pandas_nightly", "/mypy_nightly", "/pyrefly_all"]'), github.event.comment.body) && github.event.comment.author_association == 'MEMBER'
 
     steps:
       - name: Resolve comment command
@@ -34,18 +34,10 @@ jobs:
               echo "poe_command=mypy --mypy_nightly" >> "${GITHUB_OUTPUT}"
               echo "check_name=Mypy nightly tests" >> "${GITHUB_OUTPUT}"
               ;;
-            /pyrefly_strict)
-              echo "poe_command=pyrefly_strict" >> "${GITHUB_OUTPUT}"
-              echo "check_name=Pyrefly tests strict preset" >> "${GITHUB_OUTPUT}"
-              ;;
             /pyrefly_all)
               echo "poe_command=pyrefly_all" >> "${GITHUB_OUTPUT}"
               echo "check_name=Pyrefly tests all preset" >> "${GITHUB_OUTPUT}"
               ;;
-            /ty_all)
-              echo "poe_command=ty_all" >> "${GITHUB_OUTPUT}"
-              echo "check_name=Ty tests all rules raising errors" >> "${GITHUB_OUTPUT}"
-              ;;
             *)
               echo "Unknown command: ${COMMENT_BODY}" >&2
               exit 1

.github/workflows/optional.yml

@@ -51,22 +51,6 @@ jobs:
     - name: Run mypy tests with mypy nightly
       run: poetry run poe mypy --mypy_nightly
 
-  pyrefly_strict:
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-
-    steps:
-    - uses: actions/checkout@v7
-
-    - name: Install project dependencies
-      uses: ./.github/setup
-      with:
-        os: ubuntu-latest
-        python-version: '3.14'
-
-    - name: Run pyrefly tests with preset 'strict'
-      run: poetry run poe pyrefly_strict
-
   pyrefly_all:
     runs-on: ubuntu-latest
     timeout-minutes: 10
@@ -82,19 +66,3 @@ jobs:
 
     - name: Run pyrefly tests with preset 'all'
       run: poetry run poe pyrefly_all
-  
-  ty_all:
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-
-    steps:
-    - uses: actions/checkout@v7
-
-    - name: Install project dependencies
-      uses: ./.github/setup
-      with:
-        os: ubuntu-latest
-        python-version: '3.14'
-
-    - name: Run ty tests with all rules raising errors
-      run: poetry run poe ty_all

docs/tests.md

@@ -21,15 +21,11 @@ The following tests are **optional**. Some of them are run by the CI but it is o
 
 - Run pytest against pandas nightly: `poe pytest --nightly`
 - Use mypy nightly to validate the annotations: `poe mypy --mypy_nightly`
-- Use pyrefly with [preset](https://pyrefly.org/en/docs/configuration/#preset) 'strict': `poe pyrefly_strict`
 - Use pyrefly with preset 'all': `poe pyrefly_all`
-- Use ty with [all rules raising errors](https://docs.astral.sh/ty/rules/#rule-levels): `poe ty_all`
 - Run stubtest to compare the installed pandas-stubs against pandas (this will fail): `poe stubtest`. If you have created an allowlist to ignore certain errors: `poe stubtest path_to_the_allow_list`
 
 Among the tests above, the following can be run directly during a PR by commenting in the discussion.
 
 - Run pytest against pandas nightly by commenting `/pandas_nightly`
 - Use mypy nightly to validate the annotations by commenting `/mypy_nightly`
-- Use pyrefly with preset 'strict': `/pyrefly_strict`
 - Use pyrefly with preset 'all': `/pyrefly_all`
-- Use ty with all rules raising errors: `/ty_all`

pandas-stubs/_config/config.pyi

@@ -10,6 +10,8 @@ from typing import (
     type_check_only,
 )
 
+from typing_extensions import override
+
 def get_option(pat: str) -> Any: ...
 @overload
 def set_option(*args: dict[str, Any]) -> None: ...
@@ -70,10 +72,12 @@ def describe_option(pat: str, _print_desc: Literal[True] = True) -> None: ...
 
 class DictWrapper:
     def __init__(self, d: dict[str, Any], prefix: str = "") -> None: ...
+    @override
     def __setattr__(
         self, key: str, val: str | bool | int | DictWrapper | None
     ) -> None: ...
     def __getattr__(self, key: str) -> str | bool | int | DictWrapper | None: ...
+    @override
     def __dir__(self) -> Iterable[str]: ...
 
 @type_check_only

pandas-stubs/_libs/interval.pyi

@@ -8,18 +8,17 @@ from typing import (
 )
 
 import numpy as np
-from pandas import (
-    IntervalIndex,
-    Series,
-    Timedelta,
-    Timestamp,
-)
 from pandas._stubs_only import (
     OrderableScalarT,
     OrderableT,
     OrderableTimesT,
 )
+from pandas.core.indexes.interval import IntervalIndex
+from pandas.core.series import Series
+from typing_extensions import override
 
+from pandas._libs.tslibs.timedeltas import Timedelta
+from pandas._libs.tslibs.timestamps import Timestamp
 from pandas._typing import (
     IntervalClosedType,
     IntervalT,
@@ -78,6 +77,7 @@ class Interval(IntervalMixin, Generic[OrderableT]):
         right: OrderableT,
         closed: IntervalClosedType = "right",
     ) -> Self: ...
+    @override
     def __hash__(self) -> int: ...
     @overload
     def __contains__(self: Interval[int], key: float | np.floating) -> bool: ...
@@ -191,18 +191,24 @@ class Interval(IntervalMixin, Generic[OrderableT]):
     @overload
     def __le__(self: IntervalT, other: IntervalIndex[IntervalT]) -> np_1darray_bool: ...
     @overload
-    def __eq__(self, other: Interval[OrderableT]) -> bool: ...  # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
+    @override
+    def __eq__(self, other: Interval[OrderableT]) -> bool: ...  # type: ignore[overload-overlap]
     @overload
     def __eq__(self: IntervalT, other: IntervalIndex[IntervalT]) -> np_1darray_bool: ...
     @overload
     def __eq__(self, other: Series[OrderableT]) -> Series[bool]: ...  # type: ignore[overload-overlap]
     @overload
-    def __eq__(self, other: object) -> Literal[False]: ...
+    def __eq__(  # pyright: ignore[reportOverlappingOverload]
+        self, other: object
+    ) -> Literal[False]: ...
     @overload
-    def __ne__(self, other: Interval[OrderableT]) -> bool: ...  # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
+    @override
+    def __ne__(self, other: Interval[OrderableT]) -> bool: ...  # type: ignore[overload-overlap]
     @overload
     def __ne__(self: IntervalT, other: IntervalIndex[IntervalT]) -> np_1darray_bool: ...
     @overload
     def __ne__(self, other: Series[OrderableT]) -> Series[bool]: ...  # type: ignore[overload-overlap]
     @overload
-    def __ne__(self, other: object) -> Literal[True]: ...
+    def __ne__(  # pyright: ignore[reportOverlappingOverload]
+        self, other: object
+    ) -> Literal[True]: ...

pandas-stubs/_libs/missing.pyi

@@ -11,14 +11,18 @@ import numpy as np
 from pandas.core.arrays.boolean import BooleanArray
 from pandas.core.indexes.base import Index
 from pandas.core.series import Series
+from typing_extensions import override
 
 from pandas._typing import Scalar
 
 @final
 class NAType:
     def __new__(cls, *args: Any, **kwargs: Any) -> Self: ...
+    @override
     def __format__(self, format_spec: str) -> str: ...
+    @override
     def __hash__(self) -> int: ...
+    @override
     def __reduce__(self) -> str: ...
     @overload
     def __add__(self, other: Series, /) -> Series: ...
@@ -107,19 +111,19 @@ class NAType:
     @overload
     def __rdivmod__(self, other: Scalar, /) -> tuple[NAType, NAType]: ...
     @overload  # type: ignore[override]
-    def __eq__(  # pyrefly: ignore[bad-override]
-        self, other: Series, /
-    ) -> Series[bool]: ...
+    @override
+    # pyrefly: ignore[bad-override]
+    def __eq__(self, other: Series, /) -> Series[bool]: ...
     @overload
     def __eq__(self, other: Index, /) -> BooleanArray: ...
     @overload
     def __eq__(  # pyright: ignore[reportIncompatibleMethodOverride] # ty: ignore[invalid-method-override]
         self, other: Scalar, /
     ) -> NAType: ...
     @overload  # type: ignore[override]
-    def __ne__(  # pyrefly: ignore[bad-override]
-        self, other: Series, /
-    ) -> Series[bool]: ...
+    @override
+    # pyrefly: ignore[bad-override]
+    def __ne__(self, other: Series, /) -> Series[bool]: ...
     @overload
     def __ne__(self, other: Index, /) -> BooleanArray: ...
     @overload

pandas-stubs/_libs/tslibs/nattype.pyi

@@ -11,6 +11,7 @@ from typing import (
 )
 
 import numpy as np
+from typing_extensions import override
 
 from pandas._libs.tslibs.period import Period
 from pandas._typing import (
@@ -34,6 +35,7 @@ class _NatComparison:
 @final
 class NaTType:
     value: np.int64
+    @override
     def __hash__(self) -> int: ...
     def asm8(self) -> np.datetime64: ...
     def to_datetime64(self) -> np.datetime64: ...
@@ -147,7 +149,9 @@ class NaTType:
     # inject Period properties
     @property
     def qyear(self) -> float: ...
+    @override
     def __eq__(self, other: object) -> bool: ...
+    @override
     def __ne__(self, other: object) -> bool: ...
     __lt__: _NatComparison
     __le__: _NatComparison

pandas-stubs/_libs/tslibs/offsets.pyi

@@ -15,8 +15,9 @@ from typing import (
 
 from dateutil.relativedelta import weekday as WeekdayClass
 import numpy as np
-from pandas import Timestamp
+from typing_extensions import override
 
+from pandas._libs.tslibs.timestamps import Timestamp
 from pandas._typing import (
     ShapeT,
     np_ndarray_object,
@@ -32,8 +33,11 @@ class ApplyTypeError(TypeError): ...
 class BaseOffset:
     n: int
     def __init__(self, n: int = ..., normalize: bool = ...) -> None: ...
+    @override
     def __eq__(self, other: object) -> bool: ...
+    @override
     def __ne__(self, other: object) -> bool: ...
+    @override
     def __hash__(self) -> int: ...
     @property
     def kwds(self) -> dict[str, Any]: ...
@@ -107,6 +111,7 @@ class SingleConstructorOffset(BaseOffset): ...
 class Tick(SingleConstructorOffset):
     def __init__(self, n: int = ..., normalize: bool = ...) -> None: ...
     @property
+    @override
     def nanos(self) -> int: ...
 
 class Day(Tick): ...

pandas-stubs/_libs/tslibs/period.pyi

@@ -11,6 +11,7 @@ from pandas.core.indexes.base import Index
 from pandas.core.indexes.period import PeriodIndex
 from pandas.core.indexes.timedeltas import TimedeltaIndex
 from pandas.core.series import Series
+from typing_extensions import override
 
 from pandas._libs.tslibs import NaTType
 from pandas._libs.tslibs.offsets import BaseOffset
@@ -80,15 +81,18 @@ class Period(PeriodMixin):
     #  ignore[misc] here because we know all other comparisons
     #  are False, so we use Literal[False]
     @overload
-    def __eq__(self, other: Self) -> bool: ...  # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
+    @override
+    def __eq__(self, other: Self) -> bool: ...  # type: ignore[overload-overlap]
     @overload
     def __eq__(self, other: Index) -> np_1darray_bool: ...  # type: ignore[overload-overlap]
     @overload
     def __eq__(self, other: Series[Period]) -> Series[bool]: ...  # type: ignore[overload-overlap]
     @overload
     def __eq__(self, other: np_ndarray_object[ShapeT]) -> np_ndarray_bool[ShapeT]: ...  # type: ignore[overload-overlap]
     @overload
-    def __eq__(self, other: object) -> Literal[False]: ...
+    def __eq__(  # pyright: ignore[reportOverlappingOverload]
+        self, other: object
+    ) -> Literal[False]: ...
     @overload
     def __ge__(self, other: Self) -> bool: ...
     @overload
@@ -124,15 +128,18 @@ class Period(PeriodMixin):
     #  ignore[misc] here because we know all other comparisons
     #  are False, so we use Literal[False]
     @overload
-    def __ne__(self, other: Self) -> bool: ...  # type: ignore[overload-overlap] # pyright: ignore[reportOverlappingOverload]
+    @override
+    def __ne__(self, other: Self) -> bool: ...  # type: ignore[overload-overlap]
     @overload
     def __ne__(self, other: Index) -> np_1darray_bool: ...  # type: ignore[overload-overlap]
     @overload
     def __ne__(self, other: Series[Period]) -> Series[bool]: ...  # type: ignore[overload-overlap]
     @overload
     def __ne__(self, other: np_ndarray_object[ShapeT]) -> np_ndarray_bool[ShapeT]: ...  # type: ignore[overload-overlap]
     @overload
-    def __ne__(self, other: object) -> Literal[True]: ...
+    def __ne__(  # pyright: ignore[reportOverlappingOverload]
+        self, other: object
+    ) -> Literal[True]: ...
     @property
     def day(self) -> int: ...
     @property
@@ -144,6 +151,7 @@ class Period(PeriodMixin):
     @property
     def days_in_month(self) -> int: ...
     @property
+    @override
     def end_time(self) -> Timestamp: ...
     @property
     def freq(self) -> BaseOffset: ...
@@ -166,6 +174,7 @@ class Period(PeriodMixin):
     @property
     def is_leap_year(self) -> bool: ...
     @property
+    @override
     def start_time(self) -> Timestamp: ...
     @property
     def week(self) -> int: ...