Skip to content

Commit bc5b697

Browse files
committed
xfails and fixes
1 parent d12f66d commit bc5b697

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

pandas/tests/io/pytables/test_append.py

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
import numpy as np
66
import pytest
77

8+
from pandas._config import using_string_dtype
9+
810
from pandas._libs.tslibs import Timestamp
911
from pandas.compat import PY312
1012

@@ -514,6 +516,7 @@ def test_append_with_empty_string(setup_path):
514516
tm.assert_frame_equal(store.select("df"), df)
515517

516518

519+
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
517520
def test_append_with_data_columns(setup_path):
518521
with ensure_clean_store(setup_path) as store:
519522
df = DataFrame(

pandas/tests/io/pytables/test_categorical.py

+3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import numpy as np
22
import pytest
33

4+
from pandas._config import using_string_dtype
5+
46
from pandas import (
57
Categorical,
68
DataFrame,
@@ -138,6 +140,7 @@ def test_categorical(setup_path):
138140
store.select("df3/meta/s/meta")
139141

140142

143+
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
141144
def test_categorical_conversion(tmp_path, setup_path):
142145
# GH13322
143146
# Check that read_hdf with categorical columns doesn't return rows if

pandas/tests/io/pytables/test_errors.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ def test_unimplemented_dtypes_table_columns(setup_path):
9191
msg = "|".join(
9292
[
9393
re.escape(
94-
"Cannot serialize the column [datetime1] because its data contents "
95-
"are not [string] but [date] object dtype"
94+
"Cannot serialize the column [datetime1]\nbecause its data "
95+
"contents are not [string] but [date] object dtype"
9696
),
9797
re.escape("[date] is not implemented as a table column"),
9898
]

pandas/tests/io/pytables/test_select.py

+4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import numpy as np
22
import pytest
33

4+
from pandas._config import using_string_dtype
5+
46
from pandas._libs.tslibs import Timestamp
57
from pandas.compat import PY312
68

@@ -664,6 +666,7 @@ def test_frame_select(setup_path, request):
664666
# store.select('frame', [crit1, crit2])
665667

666668

669+
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
667670
def test_frame_select_complex(setup_path):
668671
# select via complex criteria
669672

@@ -977,6 +980,7 @@ def test_query_long_float_literal(setup_path):
977980
tm.assert_frame_equal(expected, result)
978981

979982

983+
@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
980984
def test_query_compare_column_type(setup_path):
981985
# GH 15492
982986
df = DataFrame(

0 commit comments

Comments
 (0)