-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: displaying string dtypes not showing storage option #50151
Conversation
Looks to be a doctest error
|
def test_to_string_string_dtype(): | ||
# GH#50099 | ||
if pa_version_under6p0: | ||
pytest.skip() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could you use the pytest.mark.skipif
decorator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, changed
Yeah I don't think at the moment. Not sure why Looks like I actually hacked around this when creating
|
Thx, fixed the doctest. Ok then can keep as is :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM can merge on green
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @phofl!
As far as I remember, this was actually done intentionally. And I personally I would prefer to keep this. But let's discuss on the issue (will reopen that one). |
DataFrame.dtypes
doesn't include backend forstring
columns #50099 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.cc @mroeschke not saying that this is a good fix, but this shows that we have to use repr for the string dtypes in some way. Is there a more general rule to accomplish this?