added negative value support in pct_changes of generic.py #56627
Conversation
|
Thanks for the PR. Few points:
|
|
@asishm-wk I am not able to figure out the issue with the failing check |
|
The error comes from mypy - if you click on the failed build.
Looks like you removed the type ignore comment when you made the changes (needs to be there in both the if and else statements). |
pandas/core/generic.py
Outdated
| @@ -12145,7 +12146,10 @@ def pct_change( | |||
|
|
|||
| shifted = data.shift(periods=periods, freq=freq, axis=axis, **kwargs) | |||
| # Unsupported left operand type for / ("Self") | |||
| rs = data / shifted - 1 # type: ignore[operator] | |||
| if use_absolute_value: | |||
| rs = rs = (data - shifted) / abs(shifted) # type: ignore[operator] | |||
There was a problem hiding this comment.
| rs = rs = (data - shifted) / abs(shifted) # type: ignore[operator] | |
| rs = (data - shifted) / abs(shifted) # type: ignore[operator] |
pandas/tests/dtypes/test_generic.py
Outdated
| @@ -1,3 +1,4 @@ | |||
| import random | |||
There was a problem hiding this comment.
is the import and setting the seed below required?
There was a problem hiding this comment.
will check and remove if not required
|
I appreciate the PR but I am not sure it is worth expanding the API for this. |
|
Thanks for the PR but it is a bit too early to craft a solution to the issue as it's still being actively discussed. Going to close but we can reopen if it has more acceptance from the core developers |
closes #56618