Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update html.py #59948

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update html.py #59948

wants to merge 3 commits into from
+1 −0

Conversation

JustinCapili
Copy link

Adding a mathjax_ignore as a bug fix to ensure that proper formatting is performed

@JustinCapili
Update html.py
70bf915 
Adding a mathjax_ignore as a bug fix to ensure that proper formatting is performed
@rhshadrach rhshadrach added Output-Formatting __repr__ of pandas objects, to_string Bug labels Oct 3, 2024
rhshadrach
rhshadrach requested changes Oct 5, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few requests:

  • Update the PR title to be more informative.
  • Add a note in the whatsnew for 3.0 in the bug fix section.
  • Add tests - for this, search the tests for tex2jax_ignore and add mathjax_ignore to the asserts (there are 4 tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Bug Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Disabling pandas option display.html.use_mathjax has no effect
2 participants
@JustinCapili @rhshadrach