Add new sshConnectionInfo and make sftpConnectionInfo call it. (#2719)

* Add new purpose param to sftpConnectionInfo function.

* Add new function.

* Missed renames.

* Coding standards.

Author: kporras07

src/Commands/Remote/SSHBaseCommand.php

@@ -376,7 +376,7 @@ private function getCommandSummary($command_args)
      */
     private function getConnectionString()
     {
-        $sftp = $this->environment->sftpConnectionInfo();
+        $ssh = $this->environment->sshConnectionInfo();
         $command = $this->getConfig()->get('ssh_command');
         if ($this->output()->isDebug()) {
             $command .= ' -vvv';
@@ -387,7 +387,7 @@ private function getConnectionString()
         }
         return vsprintf(
             '%s -T %s@%s -p %s -o "StrictHostKeyChecking=no" -o "AddressFamily inet"',
-            [$command, $sftp['username'], $this->lookupHostViaAlternateNameserver($sftp['host']), $sftp['port']]
+            [$command, $ssh['username'], $this->lookupHostViaAlternateNameserver($ssh['host']), $ssh['port']]
         );
     }
 

src/Models/Environment.php

@@ -985,16 +985,24 @@ public function setHttpsCertificate($certificate = [])
     }
 
     /**
-     * Gives SFTP connection info for this environment
-     *
-     * @return array
+     * Gives sftp connection info for this environment.
      */
     public function sftpConnectionInfo()
     {
         if ($this->isEvcsSite()) {
             // No SFTP for EVCS sites
             return [];
         }
+        return $this->sshConnectionInfo();
+    }
+
+    /**
+     * Gives ssh connection info for this environment
+     *
+     * @return array
+     */
+    public function sshConnectionInfo()
+    {
         $site = $this->getSite();
         if (!empty($ssh_host = $this->getConfig()->get('ssh_host'))) {
             $username = "appserver.{$this->id}.{$site->id}";