Commit 9f172e1
authored
Reason for removing - this signal handler addresses only a single kind of clean-up, but I had a more generalized and adaptive implementation in mind. If we do it this way, I can imagine more functionality being added into this and it becomes a "kitchen sink" trying to handle more and more different types of situations as they arise.. it conflates many concerns, and the more responsibilities it gains, the harder it gets to refactor it away.
What I envisioned is the signal handler setting a flag, or firing a hook, that other parts of terminus's code detect and do their own clean-up when it happens.. so if I'm terminus command X, I decide what needs to happen if I'm interrupted.
If what I imagined is infeasible, it's not hard to revert this revert and put this signal handler back, but I'd like to pause on putting it in right away.
1 parent b35b708 commit 9f172e1
2 files changed
+0
-74
lines changedThis file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
| |||
149 | 148 | | |
150 | 149 | | |
151 | 150 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | 151 | | |
156 | 152 | | |
157 | 153 | | |
| |||
237 | 233 | | |
238 | 234 | | |
239 | 235 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | 236 | | |
244 | 237 | | |
245 | 238 | | |
| |||
337 | 330 | | |
338 | 331 | | |
339 | 332 | | |
340 | | - | |
341 | 333 | | |
342 | 334 | | |
343 | 335 | | |
| |||
0 commit comments