Fix Terminus for PHP 5.5, 5.6, and 7.0 (#2264)

* Test on PHP 5.5, 5.6, and 7.0

* Remove return typehint for compatibility with older versions of PHP

* Fix plugin discovery for PHP 5.5

* Reformat const strings for compatibility with older versions of php.

* Disable long line checks in code lint

* Update to newer version of consolidation/self-update

* Moar string changes for old PHP versions

* Update README with supported PHP versions

Author: greg-1-anderson

.github/workflows/ci.yml

@@ -53,7 +53,7 @@ jobs:
     strategy:
       matrix:
         operating-system: ['ubuntu-latest', 'macos-latest']
-        php-versions: ['7.2', '7.3', '7.4']
+        php-versions: ['5.5', '5.6', '7.0', '7.2', '7.3', '7.4']
     env:
       TERMINUS_TOKEN: ${{ secrets.TERMINUS_TOKEN }}
       TERMINUS_WP_SITE: ${{ secrets.TERMINUS_WP_SITE }}

README.md

@@ -17,7 +17,7 @@ Our documentation is kept in the Terminus Manual, located here: https://pantheon
 ## Dependencies
 ### Required
 - A command-line client
-- PHP version 5.6.40 or later recommended (5.5.38 minimum)
+- PHP version 7.2 or later recommended. Any 7.x version, plus 5.6.40 and 5.5.38 are supported. Upgrade to Terminus 3 for PHP 8 support.
 - [PHP-CLI](https://www.php-cli.com/)
 - [PHP-CURL](https://php.net/manual/curl.setup.php)
 - [PHP-XML](https://php.net/manual/book.xml.php)

composer.json

@@ -48,7 +48,7 @@
       "cbf": "phpcbf --standard=tests/config/linting_ruleset.xml tests/unit_tests/* bin/terminus src/*",
       "clover": "phpunit -c tests/config/phpunit.xml.dist --coverage-clover tests/logs/clover.xml",
       "coveralls": "php vendor/bin/php-coveralls -v -c tests/config/coveralls.yml",
-      "cs": "phpcs --standard=tests/config/linting_ruleset.xml tests/unit_tests bin/terminus src",
+      "cs": "phpcs --standard=tests/config/linting_ruleset.xml --exclude=Generic.Files.LineLength tests/unit_tests bin/terminus src",
       "docs": "php scripts/make-docs.php",
       "lint": "@cs",
       "phpunit": "SHELL_INTERACTIVE=true phpunit --colors=always  -c tests/config/phpunit.xml.dist --debug",

composer.lock

@@ -292,7 +292,7 @@ public function databaseConnectionInfo()
      *
      * @return \Pantheon\Terminus\Models\Binding|null
      */
-    private function getBinding(array $bindings): ?Binding
+    private function getBinding(array $bindings)
     {
         foreach ($bindings as $binding) {
             if (!$binding instanceof Binding) {

src/Models/Environment.php

@@ -15,13 +15,6 @@ class PluginDiscovery implements LoggerAwareInterface
 {
     use LoggerAwareTrait;
 
-    /**
-     * List of all Terminus plugins that have been rolled into Terminus core.
-     */
-    const BLACKLIST = [
-        'pantheon-systems/terminus-aliases-plugin'
-    ];
-
     /**
      * @var string The path to the directory to search for plugins.
      */
@@ -44,6 +37,9 @@ public function __construct($path)
      */
     public function discover()
     {
+        $blacklist = [
+            'pantheon-systems/terminus-aliases-plugin'
+        ];
         $out = [];
         try {
             $di = new \DirectoryIterator($this->directory_path);
@@ -56,7 +52,7 @@ public function discover()
             if ($dir->isDir() && !$dir->isDot() && $dir->isReadable()) {
                 try {
                     $plugin = new PluginInfo($dir->getPathname());
-                    if (!in_array($plugin->getName(), self::BLACKLIST)) {
+                    if (!in_array($plugin->getName(), $blacklist)) {
                         $out[] = $plugin;
                     }
                 } catch (TerminusException $e) {

src/Plugins/PluginDiscovery.php

@@ -29,16 +29,9 @@ class UpdateChecker implements
     use LoggerAwareTrait;
 
     const DEFAULT_COLOR = "\e[0m";
-    const UPDATE_COMMAND = 'You can update Terminus by running `composer update` or using the Terminus installer:'
-        . PHP_EOL
-        . 'curl -O https://raw.githubusercontent.com/pantheon-systems/terminus-installer/master/builds/installer.phar '
-        . '&& php installer.phar update';
-    const UPDATE_COMMAND_PHAR = 'You can update Terminus by running:' . PHP_EOL . 'terminus self:update';
-    const UPDATE_NOTICE = 'A new Terminus version v{latest_version} is available.'
-        . PHP_EOL
-        . 'You are currently using version v{running_version}.'
-        . PHP_EOL
-        . '{update_command}';
+    const UPDATE_COMMAND = "You can update Terminus by running `composer update` or using the Terminus installer:\ncurl -O https://raw.githubusercontent.com/pantheon-systems/terminus-installer/master/builds/installer.phar && php installer.phar update";
+    const UPDATE_COMMAND_PHAR = "You can update Terminus by running:\nterminus self:update";
+    const UPDATE_NOTICE = "A new Terminus version v{latest_version} is available.\nYou are currently using version v{running_version}.\n{update_command}";
     const UPDATE_NOTICE_COLOR = "\e[38;5;33m";
     const UPDATE_VARS_COLOR = "\e[38;5;45m";