backup:restore shows confusing results when selecting a specific file

[davereid]

If a run terminus backup:restore site.env --file=site_env_date_code.tar to restore only a specific time and element, what happens is I get this output:

➜  ~ terminus backup:restore sitename.live --file=sitename_live_2025-08-07T23-52-17_UTC_database.sql.gz

 Are you sure you want to restore to live on sitename? (yes/no) [no]:
 > y

 [notice] Restored the code backup to live.
 [notice] Restored the files backup to live.
 [notice] Restored the database backup to live.

Note, I only expected to see [notice] Restored the database backup to live. happen but not code and files, even though I don't think the workkflow actually restored code and files. It made me panic on doing a rollback that included more than was expected

[stevector]

@greg-1-anderson do you have insight in what the behavior is supposed to be?

I'm not seeing how it would be possible to use --file without also using the --element flag to specify if the given file is code, files, or db. I would expect an error. Though I'm also unclear on what --element=all is supposed to mean when I would think --file could only point to one type of backup.

[davereid]

When I tried to run with both --file and --element provided, it returned an error, which I think should be expected, since by already providing a file (for a specific element), I shouldn't also provide an element.

terminus backup:restore sitename.env --file=filename_code.tar.gz --element=db
 [error]  You cannot specify a file and an element at the same time.

[melbrisgone]

@stevector Do you have update for us on this? cc: @mmenavas

[mmenavas]

@stevector I am able to reproduce the bug reported in this ticket and strongly believe when we pass the --file option, the code to restore the given backup is executed 3 times instead of just once.

After inspecting the code, I noticed the bug is caused by setting $options['element'] to all by default (even when no --element option is passed) in the restoreBackup method signature, which makes the $elements variable be assigned to ['code', 'files', 'database']. This assignment makes the processWorkflow() run 3 times, hence the 3 notices, one for each array element in $elements.

[mmenavas]

@stevector It looks like this bug was already addressed in #2664. This ticket can be closed as the issue is no longer happening on the 4.x version.