Skip to content

Conversation

@namespacebrian
Copy link
Contributor

Reverts #2685

@namespacebrian namespacebrian requested a review from a team as a code owner May 6, 2025 19:59
@namespacebrian namespacebrian merged commit 9f172e1 into 4.x May 6, 2025
9 checks passed
@namespacebrian namespacebrian deleted the revert-2685-command-signal-handler branch May 6, 2025 21:47
@namespacebrian
Copy link
Contributor Author

Reason for the revert: this signal handler assumes direct responsibility for what shutdown/clean-up tasks need to be done. I had envisioned something more adaptive/generalized where the signal handler sets a flag, or invokes more callbacks/hooks that let other parts of the code do their own clean-up tasks.

My reasoning is that keeping it in now runs the risk of more cleanup tasks being added to it, increasing its responsibilities and the amount of contexts it attempts to address.. conflation of concerns.

If what I had envisioned is infeasible, or we conclude that having this is better than nothing, we can revert this revert and easily put it back, but I'd like to pause at least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants