Skip to content

[BUGS-9774] Fix workflow:wait #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
namespacebrian wants to merge 3 commits into from
Closed

[BUGS-9774] Fix workflow:wait #2701

namespacebrian wants to merge 3 commits into from

Conversation

@namespacebrian
Copy link
Contributor

@namespacebrian namespacebrian commented Jul 14, 2025

No description provided.

kporras07
kporras07 approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@kporras07 kporras07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Commands/Workflow/WaitCommand.php
if (!$startTime) {
$startTime = time() - 60;
}
if (!empty($options['target_commit'])) {
Copy link
Contributor

@kporras07 kporras07 Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a "major-ish" change to me

Copy link
Contributor

@kporras07 kporras07 Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, we checked for one option and used a different one :/ Which should we keep? 😂

Copy link
Contributor Author

@namespacebrian namespacebrian Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mismatch'ed variable names was one of the bugs in that 6000 line PR. The code was actually never traversing the waitForCommit() path. When I discovered this bug before and corrected it, it uncovered lots of problems in the waitForCommit() code.

Thanks for pointing this out.. I just realized I probably haven't tested this path and there are probably still problems in that code.....

@namespacebrian
Copy link
Contributor Author

namespacebrian commented Jul 15, 2025

Update: confirmed that a fix in this PR re-activates waitforCommit() code that contains more bugs, so this PR cannot be merged in its current state.

I am probably going to revert the PR for the --commit parameter, re-implement that functionality in a simpler way, and bundle all those changes together.

@namespacebrian namespacebrian deleted the fix-workflow-wait branch July 23, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kporras07 kporras07 kporras07 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@namespacebrian @kporras07