[DEVX-5319] Metrics aren't yet available for Node.js sites. #2704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
approved these changes
Jul 22, 2025
Member
greg-1-anderson
left a comment
greg-1-anderson
left a comment
There was a problem hiding this comment.
This is ok, but since it won't work for currently installed versions of Terminus, my first question is whether there would be some way to modify ygg to have it return some response (e.g. error status code) from the getSiteMetrics() function that would cause Terminus to return an appropriate error message. If there's no way to do that, then I'd continue as you have here.
Contributor
|
|
namespacebrian
changed the title
namespacebrian
approved these changes
Jul 25, 2025
Contributor
|
@greg-1-anderson can you expand on "but since it won't work for currently installed versions of Terminus" ? |
Contributor
|
@greg-1-anderson answered in a meeting that he was concerned about the error behavior for someone who runs this command without having updated to a version of Terminus that includes this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.