-
Notifications
You must be signed in to change notification settings - Fork 195
Make site label available to site:list and org:site:list commands #2708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@namespacebrian can we merge now that this is approved? |
|
Needs tests before merge |
| * @group org | ||
| * @group short | ||
| */ | ||
| public function testOrgSiteListCommandWithLabelFilter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm the one that asked for stuff to be broken out to more cases— consider whether every assertion still should be in the subsequent filter test or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this comment is stale, but the 4 assertions i see below all look reasonable to me, especially considering that none of their arguments include method calls so on the surface it appears that they should all be very computationally inexpensive.
correct test error message name->label
Replicating #2665 on a branch in the main repo.
From #2665: