Skip to content

Conversation

@namespacebrian
Copy link
Contributor

Replicating #2665 on a branch in the main repo.

From #2665:

This PR fixes #1968 and does two things:

Makes the site label available to site:list and org:site:list commands when using the --field/--fields options
Adds the ability to filter by site label using the --filter option: --filter='label*=foo'
org:site:list did not have default fields so I set them to keep the default output the same.

Thanks!

@namespacebrian namespacebrian requested a review from a team as a code owner July 30, 2025 14:03
@stevector
Copy link
Contributor

@namespacebrian can we merge now that this is approved?

@jazzsequence
Copy link
Contributor

Needs tests before merge

@kporras07 kporras07 assigned kporras07 and unassigned namespacebrian Sep 8, 2025
* @group org
* @group short
*/
public function testOrgSiteListCommandWithLabelFilter()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm the one that asked for stuff to be broken out to more cases— consider whether every assertion still should be in the subsequent filter test or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this comment is stale, but the 4 assertions i see below all look reasonable to me, especially considering that none of their arguments include method calls so on the surface it appears that they should all be very computationally inexpensive.

correct test error message name->label
@namespacebrian namespacebrian merged commit 65936ae into 4.x Sep 9, 2025
6 of 7 checks passed
@namespacebrian namespacebrian deleted the pr2665 branch September 9, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 'label' to output of site:list and org:site:list

7 participants