Skip to content

Conversation

@pwtyler
Copy link
Member

@pwtyler pwtyler commented Sep 22, 2025

Summary

  • Add php_runtime_generation field label to env:list command to expose this field in the output. Field is optional.
  • Add test coverage for php_runtime_generation field in env:list functional tests
  • Fix indentation in Environment.php getPHPRuntimeGeneration method

Background

This addresses issue #2720 by adding the php_runtime_generation field to the env:list command output. The underlying data was already available in the Environment model's serialize() method, but the field label was missing from the ListCommand, preventing it from being displayed in the output.

Changes

  1. src/Commands/Env/ListCommand.php: Added php_runtime_generation: PHP Runtime Generation to the @field-labels annotation
  2. tests/Functional/EnvCommandsTest.php: Added test assertion to verify the php_runtime_generation field is present in env:list output
  3. src/Models/Environment.php: Fixed indentation in getPHPRuntimeGeneration method

Test plan

  • Verify field label is properly added to ListCommand
  • Add test coverage for the new field in functional tests
  • Run existing test suite to ensure no regressions
  • Test env:list command output includes php_runtime_generation field
% ./bin/terminus env:list $MY_SITE --fields=id,php_runtime_generation
 ----------- ------------------------
  ID          PHP Runtime Generation
 ----------- ------------------------
  test        1
  newenv      2
  autopilot   2
  live        1
  dev         2
 ----------- ------------------------
./bin/terminus env:list $MY_SITE --fields="ID","PHP Runtime Generation"
 ----------- ------------------------
  ID          PHP Runtime Generation
 ----------- ------------------------
  test        1
  newenv      2
  autopilot   2
  live        1
  dev         2
 ----------- ------------------------

Resolves #2720

- Add php_runtime_generation field label to env:list command
- Add test coverage for php_runtime_generation field in env:list
- Fix indentation in Environment.php getPHPRuntimeGeneration method

Resolves #2720
@pwtyler pwtyler requested a review from a team as a code owner September 22, 2025 22:51
@pwtyler pwtyler changed the title Add php_runtime_generation field to env:list command output [minor] Add php_runtime_generation field to env:list command output Sep 23, 2025
@pwtyler pwtyler changed the title [minor] Add php_runtime_generation field to env:list command output [minor] add php runtime generation to env:list Sep 23, 2025
@pwtyler pwtyler merged commit 3e2a0a8 into 4.x Sep 24, 2025
9 checks passed
@pwtyler pwtyler deleted the add-php-runtime-generation-to-env-list branch September 24, 2025 14:31
namespacebrian added a commit that referenced this pull request Sep 29, 2025
Include all changes since 4.0.3:
- Add PHP runtime generation and version to env:list (#2729, #2732)
- Fix workflow:wait timeout to use warnings instead of errors (#2724)
- Preserve consolidation filter hook when running composer update (#2728)
namespacebrian added a commit that referenced this pull request Oct 7, 2025
* Update version to 4.1.0 for release

* Fix changelog format to match existing convention (remove square brackets)

* Add complete changelog entries for 4.1.0 release

Include all changes since 4.0.3:
- Add PHP runtime generation and version to env:list (#2729, #2732)
- Fix workflow:wait timeout to use warnings instead of errors (#2724)
- Preserve consolidation filter hook when running composer update (#2728)

* Remove internal build script change from changelog

PR #2728 (consolidation filter hook) is an internal build script change
not relevant to customers, so removing from changelog per documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add php_runtime_generation field to env:list

3 participants