Skip to content

Conversation

@pwtyler
Copy link
Member

@pwtyler pwtyler commented Sep 26, 2025

Summary

Fixes drush_version field returning blank values in env:info command. drush_version is defined in env:info, but appears to have never worked since the method was introduced.

  • Update getDrushVersion() to use appserver_runtime.drush_version instead of deprecated drush_version setting
  • Add drush_version to Environment serialize() method for env:info output
  • Add test case

🤖 Generated with Claude Code

./bin/terminus env:info --fields=drush_version $MY_SITE.dev
 --------------- ---
  Drush Version   8
 --------------- ---

This command only returns the platform configured drush version in pantheon.yml. Most modern Drupal applications (Composer-driven) on Pantheon use the site local Drush instead. It is worth considering whether we should deprecate and remove this field as well.

% ./bin/terminus env:info --fields=drush_version $MY_D11_SITE.dev
 --------------- ----
  Drush Version   10
 --------------- ----
% ./bin/terminus drush $MY_D11_SITE.dev -- --version
Drush Commandline Tool 13.6.2.0

@pwtyler pwtyler requested a review from a team as a code owner September 26, 2025 20:44
@pwtyler pwtyler linked an issue Sep 26, 2025 that may be closed by this pull request
@pwtyler pwtyler changed the title Fix drush_version field in env:info command [patch] Fix drush_version field in env:info command Sep 26, 2025
@namespacebrian
Copy link
Contributor

namespacebrian commented Sep 29, 2025

Have we gone through all fields returned by the API when env:info is run to determine if there are any more we might add in the future?

I'd like if we did that now rather than repeatedly discovering new things terminus is already receiving that we'd like to surface to the user.

Copy link
Contributor

@namespacebrian namespacebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel strongly enough about auditing the fields terminus receives when running env:info to request changes.

Copy link
Contributor

@namespacebrian namespacebrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phil points out that this is correcting a field rather than adding a field. Since it hasn't worked for many years, it still seems like adding to me... but I guess I'll drop it for now.

@namespacebrian namespacebrian merged commit a4fe99e into 4.x Nov 3, 2025
9 checks passed
@namespacebrian namespacebrian deleted the fix-2697 branch November 3, 2025 22:09
@kaylimepy kaylimepy mentioned this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drush version no longer populated in env:info

3 participants