Allow ipython & ipywidgets v8
#50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
reviewed
Mar 1, 2023
| @@ -27,8 +27,8 @@ requires-python = ">=3.6,<3.11" | |||
| requires = [ | |||
| "dataclasses==0.8; python_version == '3.6'", | |||
| "filelock>=3.0", | |||
| "ipython>=5.5.0,<8.0", | |||
| "ipywidgets>=7.0.0,<8.0", | |||
| "ipython>=5.5.0,<9.0", | |||
There was a problem hiding this comment.
I'll give this a spin, but a major version bump could mean disaster. Have you reviewed the changelogs? Especially of ipywidgets? It's generally good form to have done so and reported that in either the change description or a PR comment. Right now we just hope we're getting lucky and the existing tests catch any API breaks the upgrade triggers.
There was a problem hiding this comment.
Makes sense - wasn't sure about the test coverage/how best to smoke-test. I'll take a look at the changelogs for ipywidgets and circle back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pants-jupyter-plugin requires
ipython < 8.0. This PR allowsipython&ipywidgetsv8.