Merge branch 'main' into restructure_jvm_docs

Author: benjyw

CONTRIBUTORS.md

@@ -48,6 +48,7 @@ Created as part of the release process.
 + Chris Heisterkamp
 + Chris Livingston
 + Chris Pesto
++ Chris Smith
 + Chris Targett
 + Chris Williams
 + Christoph Proeschel
@@ -75,6 +76,7 @@ Created as part of the release process.
 + David Taylor
 + David Turner
 + Derek Young
++ Dimitar Kovachev
 + Dimitrios Bariamis
 + Divij Rajkumar
 + Dominic Hamon
@@ -83,6 +85,7 @@ Created as part of the release process.
 + Drew Rothstein
 + Dumitru Daniliuc
 + Dylan Herman
++ Dương Đỗ Minh Châu
 + Ebube Chuba
 + Eitan Adler
 + Ekaterina Tyurina
@@ -175,6 +178,7 @@ Created as part of the release process.
 + Kaushik Srenevasan
 + Ken Howard
 + Ken Kawamoto
++ Kevin Oliveira
 + Kevin Oliver
 + Kevin Sweeney
 + Koki Nishihara
@@ -262,6 +266,7 @@ Created as part of the release process.
 + Pierre Chevalier
 + Pierre DAL-PRA
 + Qicheng Ma
++ Ramon Buckland
 + Raph Estrada
 + Raúl Cuza
 + Rhuan Barreto
@@ -347,6 +352,7 @@ Created as part of the release process.
 + offsetcyan
 + olivercoleman-switchdin
 + philipp-sontag-by
++ purajit
 + sww
 + twunderlich-grapl
 + wimax-grapl

docs/docs/helm/deployments.mdx

@@ -341,7 +341,7 @@ Continuing with the example in the previous section, we can deploy it into Kuber
 3. Post-process the Kubernetes manifests generated by Helm by replacing all references to first-party Docker images by their real final registry destination.
 4. Initiate the deployment of the final Kubernetes resources resulting from the post-processing.
 
-The `experimental-deploy` goal also supports default Helm pass-through arguments that allow to change the deployment behaviour to be either atomic or a dry-run or even what is the Kubernetes config file (the `kubeconfig` file) and target context to be used in the deployment.
+The `experimental-deploy` goal also supports default Helm pass-through arguments that allow to change the deployment behaviour to be atomic or even what is the Kubernetes config file (the `kubeconfig` file) and target context to be used in the deployment.
 
 Please note that the list of valid pass-through arguments has been limited to those that do not alter the reproducibility of the deployment (i.e. `--create-namespace` is not a valid pass-through argument). Those arguments will have equivalent fields in the `helm_deployment` target.
 
@@ -351,6 +351,12 @@ For example, to make an atomic deployment into a non-default Kubernetes context
 pants experimental-deploy src/deployments:prod -- --kube-context my-custom-kube-context --atomic
 ```
 
+To perform a dry run, use the `--dry-run` flag of the `experimental-deploy` goal.
+
+```
+pants experimental-deploy --dry-run src/deployments:prod
+```
+
 :::note How does Pants authenticate with the Kubernetes cluster?
 Short answer is: it doesn't.
 Pants will invoke Helm under the hood with the appropriate arguments to only perform the deployment. Any authentication steps that may be needed to perform the given deployment have to be done before invoking the `experimental-deploy` goal. If you are planning to run the deployment procedure from your CI/CD pipelines, ensure that all necessary preliminary steps (including authentication with the cluster) are done before the one that triggers the deployment.

docs/docs/python/overview/linters-and-formatters.mdx

@@ -26,19 +26,20 @@ Pants does several things to speed up running formatters and linters:
 
 Linter/formatter support is implemented in separate [backends](../../using-pants/key-concepts/backends.mdx) so that they are easy to opt in to individually:
 
-| Backend                                       | Tool                                                                                                                       |
-| :-------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------- |
-| `pants.backend.python.lint.bandit`            | [Bandit](https://bandit.readthedocs.io/en/latest/): security linter                                                        |
-| `pants.backend.python.lint.black`             | [Black](https://black.readthedocs.io/en/stable/): code formatter                                                           |
-| `pants.backend.python.lint.docformatter`      | [Docformatter](https://pypi.org/project/docformatter/): docstring formatter                                                |
-| `pants.backend.python.lint.flake8`            | [Flake8](https://flake8.pycqa.org/en/latest/): style and bug linter                                                        |
-| `pants.backend.python.lint.isort`             | [isort](https://readthedocs.org/projects/isort/): import statement formatter                                               |
-| `pants.backend.python.lint.pydocstyle`        | [Pydocstyle](https://pypi.org/project/pydocstyle/): docstring linter                                                       |
-| `pants.backend.python.lint.pylint`            | [Pylint](https://pylint.pycqa.org/): style and bug linter                                                                  |
-| `pants.backend.python.lint.yapf`              | [Yapf](https://github.com/google/yapf): code formatter                                                                     |
-| `pants.backend.python.lint.autoflake`         | [Autoflake](https://github.com/myint/autoflake): remove unused imports                                                     |
-| `pants.backend.python.lint.pyupgrade`         | [Pyupgrade](https://github.com/asottile/pyupgrade): automatically update code to use modern Python idioms like `f-strings` |
-| `pants.backend.experimental.python.lint.ruff` | [Ruff](https://beta.ruff.rs/docs/): an extremely fast Python linter, written in Rust.                                      |
+| Backend                                              | Tool                                                                                                                       |
+| :--------------------------------------------------- | :------------------------------------------------------------------------------------------------------------------------- |
+| `pants.backend.python.lint.bandit`                   | [Bandit](https://bandit.readthedocs.io/en/latest/): security linter                                                        |
+| `pants.backend.python.lint.black`                    | [Black](https://black.readthedocs.io/en/stable/): code formatter                                                           |
+| `pants.backend.python.lint.docformatter`             | [Docformatter](https://pypi.org/project/docformatter/): docstring formatter                                                |
+| `pants.backend.python.lint.flake8`                   | [Flake8](https://flake8.pycqa.org/en/latest/): style and bug linter                                                        |
+| `pants.backend.python.lint.isort`                    | [isort](https://readthedocs.org/projects/isort/): import statement formatter                                               |
+| `pants.backend.python.lint.pydocstyle`               | [Pydocstyle](https://pypi.org/project/pydocstyle/): docstring linter                                                       |
+| `pants.backend.python.lint.pylint`                   | [Pylint](https://pylint.pycqa.org/): style and bug linter                                                                  |
+| `pants.backend.python.lint.yapf`                     | [Yapf](https://github.com/google/yapf): code formatter                                                                     |
+| `pants.backend.python.lint.autoflake`                | [Autoflake](https://github.com/myint/autoflake): remove unused imports                                                     |
+| `pants.backend.python.lint.pyupgrade`                | [Pyupgrade](https://github.com/asottile/pyupgrade): automatically update code to use modern Python idioms like `f-strings` |
+| `pants.backend.experimental.python.lint.ruff.check`  | [Ruff (for linting)](https://docs.astral.sh/ruff/linter/): an extremely fast Python linter, written in Rust.               |
+| `pants.backend.experimental.python.lint.ruff.format` | [Ruff (for formatting)](https://docs.astral.sh/ruff/formatter/): an extremely fast Python code formatter, written in Rust. |
 
 To enable, add the appropriate backends in `pants.toml`:
 

docs/docs/python/overview/pex.mdx

@@ -87,7 +87,8 @@ In these cases you can override the default shebang using the [`shebang`](../../
 
 Pants makes use of the [Pex](https://github.com/pex-tool/pex) command-line tool internally for building PEXes. The Pex version that Pants uses is specified by the `version` option under the `pex-cli` subsystem. The known Pex versions are specified by the `known_versions` option under the `pex-cli` subsystem. You can see all Pex tool options and their current values by running `pants help-advanced pex-cli`. To upgrade the Pex version, update these option values accordingly. For instance, in `pants.toml`, to upgrade to Pex 2.1.143:
 
-```[pex-cli]
+```
+[pex-cli]
 version = "v2.1.143"
 known_versions = [
   "v2.1.143|macos_arm64|7dba8776000b4f75bc9af850cb65b2dc7720ea211733e8cb5243c0b210ef3c19|4194291",
@@ -101,6 +102,7 @@ The Pex version determines which Pip versions are supported. To see the lists of
 
 The Pip version that Pex uses is determined by the `pip_version` option in Pants. To upgrade the Pip version, update this option value accordingly. For instance, in `pants.toml`, to set the Pip version to be the latest supported by Pex:
 
-```[python]
+```
+[python]
 pip_version = "latest"
 ```

docs/docs/terraform/index.mdx

@@ -175,3 +175,9 @@ Apply complete! Resources: 4 added, 0 changed, 0 destroyed.
 ```
 
 You can set auto approve by adding `-auto-approve` to the `[download-terraform].args` setting in `pants.toml`. You can also set it for a single pants invocation with `--download-terraform-args='-auto-approve'`, for example `pants experimental-deploy "--download-terraform-args='-auto-approve'"`.
+
+To run `terraform plan`, use the `--dry-run` flag of the `experimental-deploy` goal.
+
+```
+pants experimental-deploy --dry-run ::
+```

docs/docs/using-pants/key-concepts/backends.mdx

@@ -98,7 +98,8 @@ The list of all backends (both stable and experimental) is also available via `p
 | `pants.backend.experimental.python.framework.django`               | Enables better support for projects using Django: [https://www.djangoproject.com](https://www.djangoproject.com)                                      |                                                                                                       |
 | `pants.backend.experimental.python.framework.stevedore`            | Enables better support for projects using stevedore: [https://docs.openstack.org/stevedore/](https://docs.openstack.org/stevedore/)                   |                                                                                                       |
 | `pants.backend.experimental.python.lint.add_trailing_comma`        | Enables add-trailing-comma, a Python code formatter: [https://github.com/asottile/add-trailing-comma](https://github.com/asottile/add-trailing-comma) | [`add-trailing-comma`](../../../reference/subsystems/add-trailing-comma.mdx)                          |
-| `pants.backend.experimental.python.lint.ruff`                      | Enables Ruff, an extremely fast Python linter: [https://beta.ruff.rs/docs/](https://beta.ruff.rs/docs/)                                               | [Linters and formatters](../../python/overview/linters-and-formatters.mdx)                            |
+| `pants.backend.experimental.python.lint.ruff.check`                | Enables Ruff (for `lint`), an extremely fast Python linter: [https://docs.astral.sh/ruff/linter/](https://docs.astral.sh/ruff/linter/)                | [Linters and formatters](../../python/overview/linters-and-formatters.mdx)                            |
+| `pants.backend.experimental.python.lint.ruff.format`               | Enables Ruff (for `fmt`), an extremely fast Python code formatter: [https://docs.astral.sh/ruff/formatter/](https://docs.astral.sh/ruff/formatter/)   | [Linters and formatters](../../python/overview/linters-and-formatters.mdx)                            |
 | `pants.backend.experimental.python.packaging.pyoxidizer`           | Enables `pyoxidizer_binary` target.                                                                                                                   | [PyOxidizer](../../python/integrations/pyoxidizer.mdx)                                                |
 | `pants.backend.experimental.python.typecheck.pyright`              | Enables Pyright, a Python type checker: [https://github.com/microsoft/pyright](https://github.com/microsoft/pyright)                                  |                                                                                                       |
 | `pants.backend.experimental.python.typecheck.pytype`               | Enables Pytype, a Python type checker: [https://google.github.io/pytype/](https://google.github.io/pytype/)                                           |                                                                                                       |

docs/docs/using-pants/key-concepts/options.mdx

@@ -105,9 +105,8 @@ repo_host = "repo.%(domain)s"
 indexes.add = ["https://%(env.PY_REPO)s@%(repo_host)s/index"]
 ```
 
-Learn more about exporting environment variables in the
-[`.pants.bootstrap`](../using-pants/key-concepts/options.mdx#pantsbootstrap-file)) Bash script that is sourced
-before Pants runs.
+Learn more about exporting environment variables in the [`.pants.bootstrap`](#pantsbootstrap-file))
+Bash script that is sourced before Pants runs.
 
 ## Option types
 

src/python/pants/VERSION

@@ -1 +1 @@
-2.20.0.dev7
+2.20.0a0

src/python/pants/backend/BUILD

@@ -36,7 +36,8 @@ __dependents_rules__(
             "[/build_files/fmt/yapf/register.py]",
             "[/python/lint/black/rules.py]",
             "[/python/lint/black/subsystem.py]",
-            "[/python/lint/ruff/rules.py]",
+            "[/python/lint/ruff/fmt_rules.py]",
+            "[/python/lint/ruff/check_rules.py]",
             "[/python/lint/ruff/subsystem.py]",
             "[/python/lint/yapf/rules.py]",
             "[/python/lint/yapf/subsystem.py]",

src/python/pants/backend/build_files/fmt/ruff/integration_test.py

@@ -7,7 +7,7 @@
 
 from pants.backend.build_files.fmt.ruff.register import RuffRequest
 from pants.backend.build_files.fmt.ruff.register import rules as ruff_build_rules
-from pants.backend.python.lint.ruff.rules import rules as ruff_fmt_rules
+from pants.backend.python.lint.ruff.check_rules import rules as ruff_fmt_rules
 from pants.backend.python.lint.ruff.subsystem import Ruff
 from pants.backend.python.lint.ruff.subsystem import rules as ruff_subsystem_rules
 from pants.backend.python.target_types import PythonSourcesGeneratorTarget

src/python/pants/backend/build_files/fmt/ruff/register.py

@@ -3,7 +3,7 @@
 
 from pants.backend.build_files.fmt.base import FmtBuildFilesRequest
 from pants.backend.python.lint.ruff import subsystem as ruff_subsystem
-from pants.backend.python.lint.ruff.rules import _run_ruff_fmt
+from pants.backend.python.lint.ruff.fmt_rules import _run_ruff_fmt
 from pants.backend.python.lint.ruff.subsystem import Ruff
 from pants.backend.python.subsystems.python_tool_base import get_lockfile_interpreter_constraints
 from pants.core.goals.fmt import FmtResult

src/python/pants/backend/experimental/python/lint/ruff/BUILD

@@ -1,4 +1,4 @@
-# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
+# Copyright 2024 Pants project contributors (see CONTRIBUTORS.md).
 # Licensed under the Apache License, Version 2.0 (see LICENSE).
 
 python_sources()

src/python/pants/backend/experimental/python/lint/ruff/check/BUILD

@@ -0,0 +1,4 @@
+# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
+# Licensed under the Apache License, Version 2.0 (see LICENSE).
+
+python_sources()

src/python/pants/backend/experimental/python/lint/ruff/check/__init__.py

@@ -0,0 +1,14 @@
+# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
+# Licensed under the Apache License, Version 2.0 (see LICENSE).
+
+"""Linter & formatter for Python.
+
+See https://www.pantsbuild.org/docs/python-linters-and-formatters and https://docs.astral.sh/ruff/
+"""
+
+from pants.backend.python.lint.ruff import check_rules as ruff_rules
+from pants.backend.python.lint.ruff import skip_field, subsystem
+
+
+def rules():
+    return (*ruff_rules.rules(), *skip_field.rules(), *subsystem.rules())

src/python/pants/backend/experimental/python/lint/ruff/check/register.py

@@ -0,0 +1,4 @@
+# Copyright 2024 Pants project contributors (see CONTRIBUTORS.md).
+# Licensed under the Apache License, Version 2.0 (see LICENSE).
+
+python_sources()

src/python/pants/backend/experimental/python/lint/ruff/format/BUILD

@@ -0,0 +1,14 @@
+# Copyright 2024 Pants project contributors (see CONTRIBUTORS.md).
+# Licensed under the Apache License, Version 2.0 (see LICENSE).
+
+"""Linter & formatter for Python.
+
+See https://www.pantsbuild.org/docs/python-linters-and-formatters and https://docs.astral.sh/ruff/
+"""
+
+from pants.backend.python.lint.ruff import fmt_rules as ruff_fmt_rules
+from pants.backend.python.lint.ruff import skip_field, subsystem
+
+
+def rules():
+    return (*ruff_fmt_rules.rules(), *skip_field.rules(), *subsystem.rules())

src/python/pants/backend/experimental/python/lint/ruff/format/__init__.py

@@ -6,9 +6,15 @@
 See https://www.pantsbuild.org/docs/python-linters-and-formatters and https://docs.astral.sh/ruff/
 """
 
-from pants.backend.python.lint.ruff import rules as ruff_rules
-from pants.backend.python.lint.ruff import skip_field, subsystem
+from pants.backend.experimental.python.lint.ruff.check import register as ruff_check
+from pants.base.deprecated import warn_or_error
 
 
 def rules():
-    return (*ruff_rules.rules(), *skip_field.rules(), *subsystem.rules())
+    warn_or_error(
+        "2.23.0.dev0",
+        "The `pants.backend.experimental.python.lint.ruff` backend",
+        hint="Use `pants.backend.experimental.python.lint.ruff.check` instead.",
+        start_version="2.20.0.dev7",
+    )
+    return ruff_check.rules()

src/python/pants/backend/experimental/python/lint/ruff/format/register.py

@@ -86,10 +86,17 @@ def _asm_args(
     # See:
     # - https://github.com/golang/go/blob/245e95dfabd77f337373bf2d6bb47cd353ad8d74/src/cmd/go/internal/work/gc.go#L370-L372
     # - https://github.com/golang/go/blob/245e95dfabd77f337373bf2d6bb47cd353ad8d74/src/cmd/internal/objabi/path.go#L43-L67
+    # From Go 1.22+ this flag has been removed, since we're already passing the package path, asm can make that determination,
+    # and there's no need to pass the flag anymore.
+    # See:
+    # - https://cs.opensource.google/go/go/+/72946ae8674a295e7485982fe57c65c7142b2c14
     maybe_assembling_stdlib_runtime_args = (
         ["-compiling-runtime"]
-        if import_path in ("runtime", "reflect", "syscall", "internal/bytealg")
-        or import_path.startswith("runtime/internal")
+        if not goroot.is_compatible_version("1.22")
+        and (
+            import_path in ("runtime", "reflect", "syscall", "internal/bytealg")
+            or import_path.startswith("runtime/internal")
+        )
         else []
     )