Skip to content

Commit f23d778

Browse files
authored
remove use of pkg_resources in external_tool rules (#22048)
Remove use of `pkg_resources` requirements parser in `external_tool` rules in favor of `packaging`.
1 parent 7e1467e commit f23d778

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/python/pants/core/util_rules/external_tool.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from dataclasses import dataclass
1212
from enum import Enum
1313

14-
from pkg_resources import Requirement
14+
from packaging.requirements import Requirement
1515

1616
from pants.core.goals.export import (
1717
ExportedBinary,
@@ -293,9 +293,9 @@ def check_version_constraints(self) -> None:
293293
if not self.version_constraints:
294294
return None
295295
# Note that this is not a Python requirement. We're just hackily piggybacking off
296-
# pkg_resource.Requirement's ability to check version constraints.
297-
constraints = Requirement.parse(f"{self.name}{self.version_constraints}")
298-
if constraints.specifier.contains(self.version): # type: ignore[attr-defined]
296+
# packaging.requirements.Requirement's ability to check version constraints.
297+
constraints = Requirement(f"{self.name}{self.version_constraints}")
298+
if constraints.specifier.contains(self.version):
299299
# all ok
300300
return None
301301

0 commit comments

Comments
 (0)