`./pants test` exits with status 0 after failing test build

[shelbyd]

Describe the bug
Run ./pants test ::.
Have test file (Go) fail to compile.
My error [ERROR] Completed: Compile with Go - <redacted> failed (exit code 1).
Run echo $?.

Expected:
A non-zero (failing) status code.

Observed:
A zero (successful) status code.

Pants version
2.14.0

OS
Only tested on Linux.

Additional info
Failing with a non-zero code is critical for correct use in CI. Basically every CI system will consider a command successful if the status code is 0. This breaks the ability to trust Pants output in CI.

[benjyw]

Thanks for the bug report! I reproduce on https://github.com/pantsbuild/example-golang

[benjyw]

Note that ./pants check ::, which performs minimal compilation without running tests, has exit code 1 as expected.

[benjyw]

The issue appears to be bad interaction between this logic and the fact that the Go backend appears to mark tests that wouldn't compile as skipped, so the exit code is never reset.