Skip to content

shading_keep of deploy_jar will reserve resources from other deps #19749

Open
@da-tubi

Description

@da-tubi

Describe the bug
Here is the reproducer: https://github.com/da-tubi/pants-spark

Command line to package:

pants package src/jvm/tubi:dog

Build def snippet:

deploy_jar(
    name="dog",
    main="tubi.dog.Tail",
    output_path="dog.jar",
    dependencies=[
        "src/jvm/tubi/dog:sources",
        "src/jvm/tubi/common:sources@resolve=dog_req",
    ],
    shading_rules=[
       shading_keep(pattern="tubi.**"),
    ],
    resolve="dog_req"
)

Resources files like org/xerial/snappy/native/Linux/x86/libsnappyjava.so are reserved. They should not be reserved.

Pants version
2.18.0a0

OS
Linux

Additional info
Add any other information about the problem here, such as attachments or links to gists, if relevant.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions