Skip to content

Expose pex's --check validation #19957

Closed
Closed
@huonw

Description

@huonw

Is your feature request related to a problem? Please describe.

In 2.1.148 (pex-tool/pex#2247 / pex-tool/pex#2253), PEX adds support for --check=... to give build-time warnings/errors about --layout=zipapp PEXes that are likely to not be able to be loaded by a Python interpreter, e.g. so many files or large enough to require "ZIP64" extensions, which zipimport doesn't handle (python/cpython#77140).

This likely affects large PEXes including machine learning packages like PyTorch.

Describe the solution you'd like

For the pex_binary target:

  • ensure that any warnings are exposed
  • consider providing a pass-through check option somehow

Describe alternatives you've considered

A general mechanism for showing warnings

Additional context

N/A

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions