Skip to content

local_execution_root_dir is not "ignored" by default #21947

Open
@cburroughs

Description

@cburroughs
cd $(mktemp -d)

cat > pants.toml <<EOF
[GLOBAL]
pants_version = "2.24.1"
local_execution_root_dir = "%(buildroot)s/pants.d/tmp"

backend_packages = ["pants.backend.tools.taplo"]

# pants_ignore.add = ["pants.d/tmp"]

[source]
root_patterns = ["/src"]
EOF

mkdir -p pants.d/tmp/
echo "foo = \"world\"    " > pants.d/tmp/foo.toml

pants --no-pantsd lint ::

Results in

15:40:45.44 [INFO] Initializing Nailgun pool for 16 processes...
15:40:46.98 [INFO] Initializing Nailgun pool for 16 processes...
15:40:47.07 [WARN] Completed: Format with taplo - taplo made changes.
  pants.d/tmp/foo.toml

✕ taplo failed.

(One or more formatters failed. Run `pants fmt` to fix.)

I don't think this is a footgun and that situation would almost never be intentional.

(I stumble upon this this because a transitive dependency included test files of purposefully invalid toml)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugonboardingIssues that affect a new user's onboarding experience

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions