From 207b693fc068d2fe96d26398d9784d4dfd2101a0 Mon Sep 17 00:00:00 2001 From: Chris Smith Date: Wed, 14 Feb 2024 10:24:27 -0500 Subject: [PATCH 1/2] fix pants.log location in docs --- docs/docs/using-pants/using-pants-in-ci.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/docs/using-pants/using-pants-in-ci.mdx b/docs/docs/using-pants/using-pants-in-ci.mdx index 5be28d1b852..6f8a3d39206 100644 --- a/docs/docs/using-pants/using-pants-in-ci.mdx +++ b/docs/docs/using-pants/using-pants-in-ci.mdx @@ -237,7 +237,7 @@ attempts_default = 3 ## Tip: store Pants logs as artifacts -We recommend that you configure your CI system to store the pants log (`.pantsd.d/pants.log`) as a build artifact, so that it is available in case you need to troubleshoot CI issues. +We recommend that you configure your CI system to store the pants log (`.pants.d/workdir/pants.log`) as a build artifact, so that it is available in case you need to troubleshoot CI issues. Different CI providers and systems have different ways to configure build artifacts: From e5de145d2d13f37a3e3bb33c75ab1b4d219503d5 Mon Sep 17 00:00:00 2001 From: "chris.smith" Date: Wed, 14 Feb 2024 12:03:45 -0500 Subject: [PATCH 2/2] fix the pants.log location in the docs --- src/python/pants/engine/streaming_workunit_handler.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/python/pants/engine/streaming_workunit_handler.py b/src/python/pants/engine/streaming_workunit_handler.py index 947f30fef2c..75c64f137f4 100644 --- a/src/python/pants/engine/streaming_workunit_handler.py +++ b/src/python/pants/engine/streaming_workunit_handler.py @@ -178,9 +178,9 @@ def can_finish_async(self) -> bool: completed? The main reason to `return False` is if your callback logs in its final call, when - `finished=True`, as it may end up logging to `.pantsd.d/pants.log` instead of the console, - which is harder for users to find. Otherwise, most callbacks should return `True` to avoid - slowing down Pants from finishing the run. + `finished=True`, as it may end up logging to `.pants.d/workdir/pants.log` instead of the + console, which is harder for users to find. Otherwise, most callbacks should return `True` + to avoid slowing down Pants from finishing the run. """