From be11664b3aa141c70a84a0e388b2f6ab11b8049a Mon Sep 17 00:00:00 2001 From: Huon Wilson Date: Wed, 11 Dec 2024 13:36:57 +1100 Subject: [PATCH 1/2] Add workaround for action mishandling of draft: true -> false transition --- .github/workflows/release.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index cefdb22..72a511c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -97,7 +97,10 @@ jobs: # Build up a draft release with the artifacts from each of these jobs: - name: Create ${{ needs.determine-tag.outputs.release-tag }} Release - uses: softprops/action-gh-release@v2 + # Need to pull in https://github.com/softprops/action-gh-release/pull/316 to work-around + # double-release-creation that happens when attempting to update a draft release to + # not-draft. + uses: huonw/action-gh-release@55ec297e11bf84ff0f5893a84ea987d93489920c # v2.2.0 + https://github.com/softprops/action-gh-release/pull/316 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: @@ -131,7 +134,8 @@ jobs: setup-python: true - name: Publish ${{ needs.determine-tag.outputs.release-tag }} Release - uses: softprops/action-gh-release@v2 + # See above for discussion: + uses: huonw/action-gh-release@55ec297e11bf84ff0f5893a84ea987d93489920c # v2.2.0 + https://github.com/softprops/action-gh-release/pull/316 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: From 08c48bc52e7233a440e513747d81a94cc2f80f39 Mon Sep 17 00:00:00 2001 From: Huon Wilson Date: Wed, 11 Dec 2024 15:47:00 +1100 Subject: [PATCH 2/2] from 2.2.0 -> 2.0.9 --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 72a511c..4345494 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -100,7 +100,7 @@ jobs: # Need to pull in https://github.com/softprops/action-gh-release/pull/316 to work-around # double-release-creation that happens when attempting to update a draft release to # not-draft. - uses: huonw/action-gh-release@55ec297e11bf84ff0f5893a84ea987d93489920c # v2.2.0 + https://github.com/softprops/action-gh-release/pull/316 + uses: huonw/action-gh-release@998f80d5380609557d7464b01d59a10d845600a0 # v2.0.9 (v2) + https://github.com/softprops/action-gh-release/pull/316 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: @@ -135,7 +135,7 @@ jobs: - name: Publish ${{ needs.determine-tag.outputs.release-tag }} Release # See above for discussion: - uses: huonw/action-gh-release@55ec297e11bf84ff0f5893a84ea987d93489920c # v2.2.0 + https://github.com/softprops/action-gh-release/pull/316 + uses: huonw/action-gh-release@998f80d5380609557d7464b01d59a10d845600a0 # v2.0.9 (v2) + https://github.com/softprops/action-gh-release/pull/316 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: