You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I'm trying to use the passport strategy with the nest JS to create the dynamic strategy base on auth provider
import { Injectable, Logger } from '@nestjs/common';
import { AuthService } from 'src/modules/auth/services/auth.service';
import { IdentityProvider } from '@prisma/client';
import { HttpStatus } from '@nestjs/common/enums';
// OpenID Client v6.x imports
import * as oidc from 'openid-client';
import {
Strategy as OidcPassportStrategy,
StrategyOptions,
VerifyFunction,
} from 'openid-client/passport';
// Passport types
import type { AuthenticateCallback } from 'passport';
import type {
TokenEndpointResponse,
UserInfoResponse,
TokenEndpointResponseHelpers,
} from 'openid-client';
import { NormalizedProfile, OidcTokens } from '../interfaces/oidc.interface';
@Injectable()
export class OidcStrategyFactory {
private readonly logger = new Logger(OidcStrategyFactory.name);
// Convert any error to a proper Error object
const safeError = this.ensureError(error);
done(safeError);
return;
}
}
/**
Ensures any value is converted to a proper Error object
This addresses the "Unsafe construction of error type" issue
*/
private ensureError(value: unknown): Error {
if (value instanceof Error) {
return value;
}
let message = 'Unknown error';
if (typeof value === 'string') {
message = value;
} else if (value && typeof value === 'object' && 'message' in value) {
message = String((value as any).message);
}
return new Error(message);
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Hello, I'm trying to use the passport strategy with the nest JS to create the dynamic strategy base on auth provider
import { Injectable, Logger } from '@nestjs/common';
import { AuthService } from 'src/modules/auth/services/auth.service';
import { IdentityProvider } from '@prisma/client';
import { HttpStatus } from '@nestjs/common/enums';
// OpenID Client v6.x imports
import * as oidc from 'openid-client';
import {
Strategy as OidcPassportStrategy,
StrategyOptions,
VerifyFunction,
} from 'openid-client/passport';
// Passport types
import type { AuthenticateCallback } from 'passport';
import type {
TokenEndpointResponse,
UserInfoResponse,
TokenEndpointResponseHelpers,
} from 'openid-client';
import { NormalizedProfile, OidcTokens } from '../interfaces/oidc.interface';
@Injectable()
export class OidcStrategyFactory {
private readonly logger = new Logger(OidcStrategyFactory.name);
constructor(private readonly authService: AuthService) {}
async createStrategy(
provider: IdentityProvider,
): Promise {
try {
// Discover the OIDC configuration
const config = await oidc.discovery(
new URL(provider.issuer),
provider.clientID,
provider.clientSecret,
);
}
/**
Token verification handler with proper error handling
*/
private handleTokenVerification(
provider: IdentityProvider,
config: oidc.Configuration,
tokens: TokenEndpointResponse & TokenEndpointResponseHelpers,
done: AuthenticateCallback,
): void {
try {
const claims = tokens.claims();
const sub = claims?.sub;
if (!sub) {
// Convert to standard Error object
done(
new Error('ID token "sub" claim is missing.'),
null,
{ message: 'ID token "sub" claim is missing.' },
HttpStatus.UNAUTHORIZED,
);
return;
}
oidc
.fetchUserInfo(config, tokens.access_token, sub)
.then((userinfo) => {
const normalizedProfile = this.normalizeProfile(provider, userinfo);
})
.then((signedUser) => {
if (!signedUser?.user) {
// Use Passport's expected callback signature
done(null, false, {
message: 'User could not be verified or created.',
});
return;
}
done(null, signedUser.user);
return;
})
.catch((error: unknown) => {
this.logger.error(
'An error occurred during OIDC user verification',
error instanceof Error ? error.stack : undefined,
);
});
} catch (error) {
this.logger.error(
'An error occurred during OIDC user verification',
error instanceof Error ? error.stack : undefined,
);
// Convert any error to a proper Error object
const safeError = this.ensureError(error);
done(safeError);
return;
}
}
/**
*/
private ensureError(value: unknown): Error {
if (value instanceof Error) {
return value;
}
}
/**
*/
private normalizeProfile(
provider: IdentityProvider,
userinfo: UserInfoResponse,
): NormalizedProfile {
return {
id: userinfo.sub,
providerId: provider.id,
provider: provider.name,
displayName:
userinfo.name ||
userinfo.nickname ||
userinfo.preferred_username ||
userinfo.email ||
'Unknown User',
username: userinfo.preferred_username,
name: userinfo.name,
email: userinfo.email || '',
emailVerified: userinfo.email_verified || false,
photo: userinfo.picture,
raw: userinfo,
};
}
}
But I hit the error that I can't resolve
Unsafe construction of a(n)
errortype typed value.eslint@typescript-eslint/no-unsafe-callIs there something that I've done wrong? I can't seem to get the VerifyFunction to work at all.
Beta Was this translation helpful? Give feedback.
All reactions