Upgrade rubocop + rubocop plugins

Author: modosc

.rubocop.yml

@@ -1,9 +1,11 @@
 require:
+  - rubocop-rspec
+
+plugins:
   - rubocop-packaging
   - rubocop-performance
   - rubocop-rails
   - rubocop-rake
-  - rubocop-rspec
 
 inherit_from: .rubocop_todo.yml
 
@@ -195,3 +197,6 @@ Style/StringConcatenation:
 # performance implications. Double quotes are slightly easier to read.
 Style/StringLiterals:
   EnforcedStyle: double_quotes
+
+Gemspec/RequireMFA:
+  Enabled: false

.rubocop_todo.yml

@@ -1,16 +1,115 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-11-26 07:45:38 UTC using RuboCop version 1.22.3.
+# on 2025-03-31 17:33:57 UTC using RuboCop version 1.75.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# It may be possible for us to use safe_load, but we'd have to pass the
-# safelists, like `whitelist_classes` into our serializer, and the serializer
-# interface is a public API, so that would be a breaking change.
+# Offense count: 23
+# Configuration parameters: EnforcedStyle, AllowedGems, Include.
+# SupportedStyles: Gemfile, gems.rb, gemspec
+# Include: **/*.gemspec, **/Gemfile, **/gems.rb
+Gemspec/DevelopmentDependencies:
+  Exclude:
+    - 'paper_trail.gemspec'
+
+# Offense count: 1
+Performance/MapMethodChain:
+  Exclude:
+    - 'spec/paper_trail/version_limit_spec.rb'
+
+# Offense count: 48
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/BeEq:
+  Exclude:
+    - 'spec/controllers/articles_controller_spec.rb'
+    - 'spec/controllers/widgets_controller_spec.rb'
+    - 'spec/models/animal_spec.rb'
+    - 'spec/models/cat_spec.rb'
+    - 'spec/models/person_spec.rb'
+    - 'spec/models/plant_spec.rb'
+    - 'spec/models/widget_spec.rb'
+    - 'spec/paper_trail/cleaner_spec.rb'
+    - 'spec/paper_trail/events/base_spec.rb'
+    - 'spec/paper_trail/model_config_spec.rb'
+    - 'spec/paper_trail/request_spec.rb'
+    - 'spec/paper_trail/serializers/json_spec.rb'
+    - 'spec/paper_trail/serializers/yaml_spec.rb'
+    - 'spec/paper_trail_spec.rb'
+
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/models/management_spec.rb'
+    - 'spec/models/song_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
+# DisallowedExamples: works
+RSpec/ExampleWording:
+  Exclude:
+    - 'spec/models/song_spec.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: method_call, block
+RSpec/ExpectChange:
+  Exclude:
+    - 'spec/models/article_spec.rb'
+    - 'spec/models/not_on_update_spec.rb'
+
+# Offense count: 5
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/models/joined_version_spec.rb'
+    - 'spec/models/widget_spec.rb'
+
+# Offense count: 39
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Inferences.
+RSpec/Rails/InferredSpecType:
+  Enabled: false
+
+# Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: constant, string
+RSpec/VerifiedDoubleReference:
+  Exclude:
+    - 'spec/models/version_spec.rb'
+    - 'spec/models/widget_spec.rb'
+    - 'spec/support/shared_examples/queries.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ActiveSupportOnLoad:
+  Exclude:
+    - 'lib/paper_trail/frameworks/active_record.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ApplicationRecord:
+  Exclude:
+    - 'lib/paper_trail/frameworks/active_record/models/paper_trail/version.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
+# AllowedReceivers: ActionMailer::Preview, ActiveSupport::TimeZone
+Rails/RedundantActiveRecordAllMethod:
+  Exclude:
+    - 'spec/paper_trail/cleaner_spec.rb'
+
 # Offense count: 13
-# Cop supports --auto-correct.
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Security/YAMLLoad:
   Exclude:
     - 'lib/paper_trail/serializers/yaml.rb'
@@ -21,3 +120,12 @@ Security/YAMLLoad:
     - 'spec/models/version_spec.rb'
     - 'spec/paper_trail/events/destroy_spec.rb'
     - 'spec/paper_trail/serializer_spec.rb'
+
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/ConcatArrayLiterals:
+  Exclude:
+    - 'lib/paper_trail/queries/versions/where_object.rb'
+    - 'lib/paper_trail/queries/versions/where_object_changes.rb'
+    - 'lib/paper_trail/queries/versions/where_object_changes_from.rb'
+    - 'lib/paper_trail/queries/versions/where_object_changes_to.rb'

Rakefile

@@ -8,40 +8,40 @@ Bundler::GemHelper.install_tasks
 
 desc "Copy the database.DB.yml per ENV['DB']"
 task :install_database_yml do
-  puts format("installing database.yml for %s", ENV["DB"])
+  puts format("installing database.yml for %s", ENV.fetch("DB", nil))
 
   # It's tempting to use `git clean` here, but this rake task will be run by
   # people working on changes that haven't been committed yet, so we have to
   # be more selective with what we delete.
-  ::FileUtils.rm("spec/dummy_app/db/database.yml", force: true)
+  FileUtils.rm("spec/dummy_app/db/database.yml", force: true)
 
   FileUtils.cp(
-    "spec/dummy_app/config/database.#{ENV['DB']}.yml",
+    "spec/dummy_app/config/database.#{ENV.fetch('DB', nil)}.yml",
     "spec/dummy_app/config/database.yml"
   )
 end
 
 desc "Delete generated files and databases"
 task :clean do
-  puts format("dropping %s database", ENV["DB"])
-  case ENV["DB"]
+  puts format("dropping %s database", ENV.fetch("DB", nil))
+  case ENV.fetch("DB", nil)
   when "mysql"
     # TODO: only works locally. doesn't respect database.yml
     system "mysqladmin drop -f paper_trail_test > /dev/null 2>&1"
   when "postgres"
     # TODO: only works locally. doesn't respect database.yml
     system "dropdb --if-exists paper_trail_test > /dev/null 2>&1"
   when nil, "sqlite"
-    ::FileUtils.rm(::Dir.glob("spec/dummy_app/db/*.sqlite3"))
+    FileUtils.rm(Dir.glob("spec/dummy_app/db/*.sqlite3"))
   else
-    raise "Don't know how to clean specified RDBMS: #{ENV['DB']}"
+    raise "Don't know how to clean specified RDBMS: #{ENV.fetch('DB', nil)}"
   end
 end
 
 desc "Create the database."
 task :create_db do
-  puts format("creating %s database", ENV["DB"])
-  case ENV["DB"]
+  puts format("creating %s database", ENV.fetch("DB", nil))
+  case ENV.fetch("DB", nil)
   when "mysql"
     # TODO: only works locally. doesn't respect database.yml
     system "mysqladmin create paper_trail_test"
@@ -52,7 +52,7 @@ task :create_db do
     # noop. test.sqlite3 will be created when migration happens
     nil
   else
-    raise "Don't know how to create specified DB: #{ENV['DB']}"
+    raise "Don't know how to create specified DB: #{ENV.fetch('DB', nil)}"
   end
 end
 

lib/generators/paper_trail/install/install_generator.rb

@@ -27,8 +27,8 @@ class InstallGenerator < MigrationGenerator
       desc: "Use uuid instead of bigint for item_id type (use only if tables use UUIDs)"
     )
 
-    desc "Generates (but does not run) a migration to add a versions table." \
-         "  See section 5.c. Generators in README.md for more information."
+    desc "Generates (but does not run) a migration to add a versions table.  " \
+         "See section 5.c. Generators in README.md for more information."
 
     def create_migration_file
       add_paper_trail_migration(

lib/generators/paper_trail/update_item_subtype/update_item_subtype_generator.rb

@@ -8,7 +8,7 @@ class UpdateItemSubtypeGenerator < MigrationGenerator
     source_root File.expand_path("templates", __dir__)
 
     desc(
-      "Generates (but does not run) a migration to update item_subtype for "\
+      "Generates (but does not run) a migration to update item_subtype for " \
       "STI entries in an existing versions table."
     )
 

lib/paper_trail/frameworks/active_record.rb

@@ -3,7 +3,7 @@
 # Either ActiveRecord has already been loaded by the Lazy Load Hook in our
 # Railtie, or else we load it now.
 require "active_record"
-::PaperTrail::Compatibility.check_activerecord(::ActiveRecord.gem_version)
+PaperTrail::Compatibility.check_activerecord(ActiveRecord.gem_version)
 
 # Now we can load the parts of PT that depend on AR.
 require "paper_trail/has_paper_trail"

lib/paper_trail/frameworks/cucumber.rb

@@ -5,7 +5,7 @@
   PaperTrail.enabled = false
   PaperTrail.request.enabled = true
   PaperTrail.request.whodunnit = nil
-  PaperTrail.request.controller_info = {} if defined?(::Rails)
+  PaperTrail.request.controller_info = {} if defined?(Rails)
 end
 
 module PaperTrail

lib/paper_trail/frameworks/rspec.rb

@@ -5,24 +5,24 @@
 require "paper_trail/frameworks/rspec/helpers"
 
 RSpec.configure do |config|
-  config.include ::PaperTrail::RSpec::Helpers::InstanceMethods
-  config.extend ::PaperTrail::RSpec::Helpers::ClassMethods
+  config.include PaperTrail::RSpec::Helpers::InstanceMethods
+  config.extend PaperTrail::RSpec::Helpers::ClassMethods
 
   config.before(:each) do
-    ::PaperTrail.enabled = false
-    ::PaperTrail.request.enabled = true
-    ::PaperTrail.request.whodunnit = nil
-    ::PaperTrail.request.controller_info = {} if defined?(::Rails) && defined?(::RSpec::Rails)
+    PaperTrail.enabled = false
+    PaperTrail.request.enabled = true
+    PaperTrail.request.whodunnit = nil
+    PaperTrail.request.controller_info = {} if defined?(Rails) && defined?(RSpec::Rails)
   end
 
   config.before(:each, versioning: true) do
-    ::PaperTrail.enabled = true
+    PaperTrail.enabled = true
   end
 end
 
 RSpec::Matchers.define :be_versioned do
   # check to see if the model has `has_paper_trail` declared on it
-  match { |actual| actual.is_a?(::PaperTrail::Model::InstanceMethods) }
+  match { |actual| actual.is_a?(PaperTrail::Model::InstanceMethods) }
 end
 
 RSpec::Matchers.define :have_a_version_with do |attributes|

lib/paper_trail/model_config.rb

@@ -4,7 +4,7 @@ module PaperTrail
   # Configures an ActiveRecord model, mostly at application boot time, but also
   # sometimes mid-request, with methods like enable/disable.
   class ModelConfig
-    E_CANNOT_RECORD_AFTER_DESTROY = <<-STR.strip_heredoc.freeze
+    E_CANNOT_RECORD_AFTER_DESTROY = <<~STR
       paper_trail.on_destroy(:after) is incompatible with ActiveRecord's
       belongs_to_required_by_default. Use on_destroy(:before)
       or disable belongs_to_required_by_default.
@@ -49,7 +49,7 @@ def on_create
     def on_destroy(recording_order = "before")
       assert_valid_recording_order_for_on_destroy(recording_order)
       @model_class.send(
-        "#{recording_order}_destroy",
+        :"#{recording_order}_destroy",
         lambda do |r|
           return unless r.paper_trail.save_version?
           r.paper_trail.record_destroy(recording_order)
@@ -236,7 +236,7 @@ def setup_associations(options)
 
     def setup_callbacks_from_options(options_on = [])
       options_on.each do |event|
-        public_send("on_#{event}")
+        public_send(:"on_#{event}")
       end
     end
 

lib/paper_trail/record_trail.rb

@@ -22,7 +22,7 @@ def clear_rolled_back_versions
     # Invoked via`after_update` callback for when a previous version is
     # reified and then saved.
     def clear_version_instance
-      @record.send("#{@record.class.version_association_name}=", nil)
+      @record.send(:"#{@record.class.version_association_name}=", nil)
     end
 
     # Returns true if this instance is the current, live one;
@@ -128,7 +128,7 @@ def record_update(force:, in_after_callback:, is_touch:)
     def reset_timestamp_attrs_for_update_if_needed
       return if live?
       @record.send(:timestamp_attributes_for_update_in_model).each do |column|
-        @record.send("restore_#{column}!")
+        @record.send(:"restore_#{column}!")
       end
     end
 
@@ -202,7 +202,7 @@ def versions_between(start_time, end_time)
 
     # @api private
     def assign_and_reset_version_association(version)
-      @record.send("#{@record.class.version_association_name}=", version)
+      @record.send(:"#{@record.class.version_association_name}=", version)
       @record.send(@record.class.versions_association_name).reset
     end
 

lib/paper_trail/reifier.rb

@@ -14,7 +14,7 @@ def reify(version, options)
         attrs = version.object_deserialized
         model = init_model(attrs, options, version)
         reify_attributes(model, version, attrs)
-        model.send "#{model.class.version_association_name}=", version
+        model.send :"#{model.class.version_association_name}=", version
         model
       end
 
@@ -93,8 +93,8 @@ def init_unversioned_attrs(attrs, model)
       def reify_attribute(k, v, model, version)
         if model.has_attribute?(k)
           model[k.to_sym] = v
-        elsif model.respond_to?("#{k}=")
-          model.send("#{k}=", v)
+        elsif model.respond_to?(:"#{k}=")
+          model.send(:"#{k}=", v)
         elsif version.logger
           version.logger.warn(
             "Attribute #{k} does not exist on #{version.item_type} (Version id: #{version.id})."

lib/paper_trail/serializers/yaml.rb

@@ -27,7 +27,7 @@ def load(string)
       # recent [memory optimizations](https://github.com/paper-trail-gem/paper_trail/pull/1189),
       # when coming from `recordable_object_changes`, it will be a `HashWithIndifferentAccess`.
       def dump(object)
-        object = object.to_hash if object.is_a?(HashWithIndifferentAccess)
+        object = object.to_hash if object.is_a?(ActiveSupport::HashWithIndifferentAccess)
         ::YAML.dump object
       end
 

lib/paper_trail/version_concern.rb

@@ -320,7 +320,7 @@ def load_changeset
       end
 
       # First, deserialize the `object_changes` column.
-      changes = HashWithIndifferentAccess.new(object_changes_deserialized)
+      changes = ActiveSupport::HashWithIndifferentAccess.new(object_changes_deserialized)
 
       # The next step is, perhaps unfortunately, called "de-serialization",
       # and appears to be responsible for custom attribute serializers. For an